Skip to content

d_a_mg_fish matching#2450

Merged
hatal175 merged 1 commit intozeldaret:mainfrom
caseif:d_a_mg_fish-1
May 22, 2025
Merged

d_a_mg_fish matching#2450
hatal175 merged 1 commit intozeldaret:mainfrom
caseif:d_a_mg_fish-1

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented May 19, 2025

This PR implements d_a_mg_fish which should now be fully matching.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented May 19, 2025

Report for GZ2E01 (15463d8 - d981feb)

📈 Matched code: 61.15% (+0.44%, +50200 bytes)
📈 Linked code: 26.79% (+0.44%, +50216 bytes)

📉 d_a_mg_rod/d/actor/d_a_mg_rod | dmg_rod_class::dmg_rod_class() -69 bytes -> 77.88%
d_a_mg_fish/d/actor/d_a_mg_fish | daMg_Fish_HIO_c::daMg_Fish_HIO_c() +76 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | hit_vib_set(mg_fish_class*) +204 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | cXyz::~cXyz() +56 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | sibuki_set(mg_fish_class*, float, cXyz) +133 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_hitfish_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | pl_check(mg_fish_class*, float) +425 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | anm_init(mg_fish_class*, int, float, unsigned char, float) +169 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | mouth_open(mg_fish_class*) +89 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | mouth_close(mg_fish_class*) +89 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_lure_sub(void*, void*) +121 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_esa_sub(void*, void*) +136 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_bait_sub(void*, void*) +105 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_other_search_sub(void*, void*) +116 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | search_lure(mg_fish_class*, int) +853 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_other_bait_sub(void*, void*) +121 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | search_bait(mg_fish_class*) +437 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | nodeCallBack(J3DJoint*, int) +969 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | nodeCallBack2(J3DJoint*, int) +481 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | nodeCallBackLH(J3DJoint*, int) +204 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | nodeCallBackBB(J3DJoint*, int) +213 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_bt_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_sp_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_lh_sub(void*, void*) +105 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_bin_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_kn_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_ed_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_sy_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_bb_sub(void*, void*) +85 bytes -> 100.00%
d_a_mg_fish/d/actor/d_a_mg_fish | s_bb2_sub(void*, void*) +73 bytes -> 100.00%
...and 51 more items

Copy link
Copy Markdown
Contributor

@hatal175 hatal175 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big thing I have here is @TakaRikka 's request that TUs that are c-style (that is, lots of static functions that get the class as an argument, name usually end in "_class") are done c-style and not using inheritance.
So you want a member of type fopEn_enemy_c and then usually declare a local pointer and assign a reference to that member.

@caseif
Copy link
Copy Markdown
Contributor Author

caseif commented May 21, 2025

Thanks for all the feedback! All noted issues (plus a few extra) should be resolved and the class has been updated to use a field instead of inheritance. The TU should also now be fully matching. :)

@caseif caseif changed the title d_a_mg_fish equivalent and almost matching d_a_mg_fish matching May 21, 2025
@caseif caseif force-pushed the d_a_mg_fish-1 branch 2 times, most recently from d4d7f18 to 0b18602 Compare May 21, 2025 02:00
@hatal175 hatal175 merged commit 3c2a99e into zeldaret:main May 22, 2025
1 check passed
@caseif caseif deleted the d_a_mg_fish-1 branch May 22, 2025 14:17
meintte pushed a commit to meintte/tp that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants