d_a_obj_laundry_rope Matching#2464
Merged
hatal175 merged 7 commits intozeldaret:mainfrom May 31, 2025
Merged
Conversation
Report for GZ2E01 (4c4370b - 03043d9)📈 Matched code: 62.26% (+0.04%, +4344 bytes) ✅ 16 new matches:
|
TakaRikka
reviewed
May 31, 2025
Comment on lines
+88
to
+89
| &csXyz(0, cLib_targetAngleY(ropePosition, ropePosition + 1) + 0x4000, | ||
| -cLib_targetAngleX(ropePosition, ropePosition + 1)), |
Contributor
There was a problem hiding this comment.
this seems likely to be a temp instead
Contributor
Author
There was a problem hiding this comment.
If I assign this to a variable before the function call I don't have a match anymore.
Contributor
There was a problem hiding this comment.
Yeah it is not as easy as that. But the current version is passing a reference to a temporary object, and I am surprised MWCC is fine with it (clang is not).
Contributor
There was a problem hiding this comment.
I'm gonna merge this and let someone else figure out the solution
hatal175
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.