Continued monkey work (monkey business if you will) - Monkey-related TUs#2469
Merged
hatal175 merged 34 commits intozeldaret:mainfrom Jun 7, 2025
Merged
Continued monkey work (monkey business if you will) - Monkey-related TUs#2469hatal175 merged 34 commits intozeldaret:mainfrom
hatal175 merged 34 commits intozeldaret:mainfrom
Conversation
carter-ktb21
changed the title
Report for GZ2E01 (372d782 - 907d589)📈 Matched code: 64.42% (+0.34%, +38568 bytes) ✅ 153 new matches:
...and 123 more new matches 📈 31 improvements in unmatched functions:
...and 1 more improvements in unmatched functions |
carter-ktb21
changed the title
hatal175
reviewed
Jun 7, 2025
| @@ -18,13 +19,14 @@ class npc_ks_class { | |||
| /* 0x000 */ fopAc_ac_c actor; | |||
Contributor
There was a problem hiding this comment.
debug says this should be fopEn_enemy_c
| /* 0xC18 */ u8 field_0xc18[0xc20 - 0xc18]; | ||
| /* 0xC18 */ dPath* field_0xc18; | ||
| /* 0xC1C */ u8 field_0xc1c; | ||
| /* 0xC1D */ u8 field_0xc1d[0xc20 - 0xc1d]; |
Contributor
There was a problem hiding this comment.
You can probably drop field_0xc1d
| /* 0xAED */ u8 field_0xaed; | ||
| /* 0xAEE */ s16 field_0xaee; | ||
| /* 0xAF0 */ s16 field_0xaf0; | ||
| /* 0xAF2 */ u8 field_0xaf2[0xaf4 - 0xaf2]; |
Contributor
There was a problem hiding this comment.
field_0xaf2 can be dropped
| /* 0xE44 */ J3DModel* field_0xe44[2]; | ||
| /* 0xE4C */ dCcD_Cyl field_0xe4c; | ||
| /* 0xF88 */ u8 mType; | ||
| /* 0xF89 */ u8 field_0xf89[0xf8c - 0xf89]; |
Contributor
There was a problem hiding this comment.
field_0xf89 can be dropped
| /* 0xFD4 */ int field_0xfd4; | ||
| /* 0xFD8 */ u8 field_0xfd8; | ||
| /* 0xFD9 */ u8 field_0xfd9; | ||
| /* 0xFDA */ u8 field_0xfda[0xfdc - 0xfda]; |
Contributor
There was a problem hiding this comment.
field_0xfda can be dropped
| daNpc_Saru_Param_c::Data const daNpc_Saru_Param_c::m = { | ||
| 140.0f, | ||
| -3.0f, | ||
| 0x3F800000, |
Contributor
There was a problem hiding this comment.
Adjust all values to struct definition
|
|
||
| case 1: | ||
| JUT_ASSERT(1859, 0 != mPath.getPathInfo()); | ||
| iVar1 = cLib_calcTimer(&mEventTimer); |
Contributor
There was a problem hiding this comment.
I don't think iVar1 assignment is necessary here
| sp5c.set(5.0f, 0.0f, 200.0f); | ||
|
|
||
| int iVar1 = 0; | ||
| while (iVar1 < 1) { |
Contributor
There was a problem hiding this comment.
This looks like a for. There's a distinct chance that if you move the code in the >= 2 condition outside, this will match.
| if (i_this->field_0x1bcc != 0) { | ||
| data_80CE3C90 = 0; | ||
| #ifdef DEBUG | ||
| mDoHIO_deleteChild(data_80CE3C90); |
| i_this->field_0x1bcc = 1; | ||
| data_80CE3C90 = 1; | ||
| #ifdef DEBUG | ||
| mDoHIO_createChild("猿オリＯＢＪ", &l_HIO); // Monkey jail OBJ |
hatal175
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.