Merged
Conversation
Report for GZ2E01 (5272152 - 9d5c64a)📈 Matched code: 62.80% (+0.27%, +31384 bytes) ✅ 76 new matches:
...and 46 more new matches |
hatal175
reviewed
Jun 3, 2025
| if (i_this->field_0x754 >= 2) { | ||
| if (i_this->field_0x754 == 2) { | ||
| i_this->mMsgFlow.init(actor, 0x34c, 0, NULL); | ||
| __memcpy(unkIntArr2, unkLimitsMs2, sizeof(unkLimitsMs2)); |
Contributor
Author
There was a problem hiding this comment.
Unfortunately not, this wouldn't be legal C++ (unless I'm missing something).
| i_this->field_0x7b9 = 0; | ||
| if (i_this->field_0x754 >= 2) { | ||
| if (i_this->field_0x754 == 2) { | ||
| __memcpy(unkIntArr1, unkLimitsMs1, sizeof(unkLimitsMs1)); |
Contributor
Author
|
All problems except the ones for |
hatal175
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d_a_npc_hennashould now be equivalent with the only outstanding problem (AFAICT) being weak function ordering.