Skip to content

d_bg_w_kcol work#2490

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:d_bg_w_kcol-1
Jun 20, 2025
Merged

d_bg_w_kcol work#2490
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:d_bg_w_kcol-1

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented Jun 19, 2025

A little bit of work on d_bg_w_kcol. The actual changeset is pretty small relative to the whole class, but this file is incredibly tedious to work on.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Jun 19, 2025

Report for GZ2E01 (0a899a4 - 294a20d)

📈 2 improvements in unmatched functions:
Unit Function Bytes Before After
framework/d/d_bg_w_kcol dBgWKCol::WallCorrectSort(dBgS_Acch*) +3643 0.11% 98.67%
framework/d/d_bg_w_kcol dBgWKCol::LineCheck(cBgS_LinChk*) +30 98.04% 99.51%
📉 1 regressions in unmatched functions:
Unit Function Bytes Before After
framework/d/d_bg_w_kcol dBgWKCol::CaptPoly(dBgS_CaptPoly&) -13 97.80% 96.65%

@caseif
Copy link
Copy Markdown
Contributor Author

caseif commented Jun 19, 2025

The regression in CaptPoly isn't due to any specific change and seems to mostly be related to register shuffling - the debug version actually has a significant improvement (~86% -> ~93%).

@TakaRikka TakaRikka merged commit 25d13c7 into zeldaret:main Jun 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants