Skip to content

cstaF / obj_rope_bridge done, cleanup obj_dust#2497

Merged
hatal175 merged 4 commits intozeldaret:mainfrom
TakaRikka:cstaf
Jun 23, 2025
Merged

cstaF / obj_rope_bridge done, cleanup obj_dust#2497
hatal175 merged 4 commits intozeldaret:mainfrom
TakaRikka:cstaf

Conversation

@TakaRikka
Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Jun 23, 2025

Report for GZ2E01 (4278b8a - e5688e4)

📈 Matched code: 67.03% (+0.17%, +19480 bytes)
📈 Linked code: 27.66% (+0.16%, +18720 bytes)

✅ 68 new matches:
Unit Function Bytes Before After
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::create() +1293 0.31% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::setAnime() +1217 0.33% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::posMove() +1149 0.35% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::setLinePos() +928 0.43% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::Execute(float(**)[3][4]) +836 0.48% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::CreateHeap() +605 0.66% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::initLinePos() +596 0.67% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::mode_wait() +585 0.68% 100.00%
d_a_e_ga/d/actor/d_a_e_ga daE_Ga_Create(fopAc_ac_c*) +576 0.69% 100.00%
d_a_e_ga/d/actor/d_a_e_ga bt_fly(e_ga_class*, ga_s*) +533 0.75% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::mode_cut() +512 0.78% 100.00%
d_a_e_ga/d/actor/d_a_e_ga ga_fly(e_ga_class*, ga_s*) +500 0.79% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::initStartBrkBtk() +468 0.85% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::Draw() +468 0.85% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::CreateHeap() +461 0.86% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::action() +433 0.92% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::Create() +393 1.01% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_create1st(daObjRBridge_c*) +365 1.09% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::checkTight() +349 1.14% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::setStPos() +333 1.19% 100.00%
d_a_e_ga/d/actor/d_a_e_ga ga_control(e_ga_class*) +308 1.28% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::Draw() +280 1.41% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::Execute(float(**)[3][4]) +232 1.69% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::checkHimoCulling() +232 1.69% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::create1st() +205 1.92% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge dCcD_Cps::~dCcD_Cps() +193 2.04% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::getLinePosBrg(int, cXyz*) +181 2.17% 100.00%
d_a_cstaF/d/actor/d_a_cstaF daCstaF_c::setCollision() +176 2.22% 100.00%
d_a_e_ga/d/actor/d_a_e_ga useHeapInit(fopAc_ac_c*) +173 2.27% 100.00%
d_a_obj_rope_bridge/d/actor/d_a_obj_rope_bridge daObjRBridge_c::setBaseMtx() +169 2.33% 100.00%

...and 38 more new matches

📈 1 improvements in unmatched functions:
Unit Function Bytes Before After
d_a_obj_dust/d/actor/d_a_obj_dust daObjDust_c::Execute(float(**)[3][4]) +2 93.04% 93.21%

/* 0xAF8 */ f32 field_0xaf8;
/* 0xAFC */ mDoExt_3DlineMat1_c* mpLineMat[2];
/* 0xB04 */ cXyz* field_0xb04;
/* 0xB08 */ u8 field_0xb08[2];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe do the [end - start] for this padding field? 2 is kinda random

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an actual 2 byte array not padding

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm dumb, Didn't expand the correct file when searching for it

@hatal175 hatal175 merged commit ac0c208 into zeldaret:main Jun 23, 2025
1 check passed
@TakaRikka TakaRikka deleted the cstaf branch September 1, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants