d_a_npc_moir almost equivalent#2569
Merged
hatal175 merged 9 commits intozeldaret:mainfrom Aug 9, 2025
Merged
Conversation
Report for GZ2E01 (0759e31 - 05f25bf)📈 Matched code: 76.65% (+0.22%, +25336 bytes) ✅ 68 new matches
...and 38 more new matches 📈 4 improvements in unmatched functions
|
hatal175
reviewed
Aug 4, 2025
src/d/actor/d_a_npc_moir.cpp
Outdated
| /* 80A7D0CC-80A7D0EC 00104C 0020+00 1/1 0/0 0/0 .text createHeapCallBack__11daNpcMoiR_cFP10fopAc_ac_c */ | ||
| int daNpcMoiR_c::createHeapCallBack(fopAc_ac_c* a_this) { | ||
| daNpcMoiR_c* i_this = (daNpcMoiR_c*)a_this; | ||
| i_this->CreateHeap(); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| } | ||
|
|
||
| if (mActorMngr[0].getActorP() != NULL) { | ||
| setLookMode(2); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| if (mActorMngr[0].getActorP() != NULL) { | ||
| setLookMode(2); | ||
| } else { | ||
| setLookMode(0); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| } | ||
|
|
||
| if (mActorMngr[0].getActorP() != NULL) { | ||
| setLookMode(2); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| if (mActorMngr[0].getActorP() != NULL) { | ||
| setLookMode(2); | ||
| } else { | ||
| setLookMode(0); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| // NONMATCHING | ||
| } | ||
| case 1: | ||
| setLookMode(2); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| switch (*cutName) { | ||
| case '0001': | ||
| case '0005': | ||
| setLookMode(3); |
src/d/actor/d_a_npc_moir.cpp
Outdated
| break; | ||
|
|
||
| case '0002': | ||
| setLookMode(0); |
include/d/actor/d_a_npc_moir.h
Outdated
| /* 0xDDC */ ActionFn mAction; | ||
| /* 0xDE8 */ request_of_phase_process_class mPhase[2]; | ||
| /* 0xDF8 */ fpc_ProcID field_0xdf8; | ||
| /* 0xDFC */ fpc_ProcID field_0xdfc; |
src/d/actor/d_a_npc_moir.cpp
Outdated
| mActorMngr[i].initialize(); | ||
| } | ||
|
|
||
| field_0xdfc = cPhs_INIT_e; |
Contributor
|
I think you missed the npc enum |
hatal175
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some misplaced .data seems to be causing all but one of the remaining regallocs but I could not figure out a fix.