Misc. framework/d/ improvements#2572
Merged
TakaRikka merged 1 commit intozeldaret:mainfrom Aug 7, 2025
Merged
Conversation
Report for GZ2E01 (ee608ce - 8a1e0ef)📈 Matched code: 75.97% (+0.06%, +6580 bytes) ✅ 2 new matches
|
TakaRikka
reviewed
Aug 6, 2025
| /* 80039528 */ virtual int JSGFindObject(JStage::TObject**, char const*, | ||
| JStage::TEObject) const; | ||
|
|
||
| /* 80039AAC */ virtual ~dDemo_system_c(); |
Contributor
There was a problem hiding this comment.
are you sure all these virtuals should move? make sure it doesn't affect the vtable's function order
Contributor
Author
There was a problem hiding this comment.
This was the only way that I could find to fix virtual function ordering in the TU. As far as I can tell (based on the .data section of this TU as well as virtual function calls in .text) it shouldn't have broken vtable ordering, but I'm not sure if there's anything else I should check to verify.
caseif
force-pushed
the
framework-misc-1
branch
from
d22dccd to
8a1e0ef
Compare
TakaRikka
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some mismatches under
framework/dwitha couple ofone TU now fully matching. I noticed that other framework classes are marked as matching for JP, but I don't have a JP ROM at the moment so I can't test this for the new matches.