d_a_npc_kolin and d_a_npc_kolinb equivalent#2573
Merged
hatal175 merged 7 commits intozeldaret:mainfrom Aug 8, 2025
Merged
Conversation
Report for GZ2E01 (156d2b2 - d2c1bba)📈 Matched code: 76.31% (+0.32%, +36432 bytes) ✅ 149 new matches
...and 119 more new matches |
hatal175
reviewed
Aug 8, 2025
include/d/actor/d_a_npc_kolin.h
Outdated
| /* 0x0E44 */ J3DModel* mpClothModel; | ||
| /* 0x0E48 */ dCcD_Cyl field_0xe48; | ||
| /* 0x0F84 */ u8 mType; | ||
| /* 0x0F85 */ u8 field_0xf85[0xf88 - 0xf85]; |
Contributor
There was a problem hiding this comment.
field_0xf85 can probably be removed
include/d/actor/d_a_npc_kolin.h
Outdated
| /* 0x1018 */ u8 field_0x1018; | ||
| /* 0x1019 */ u8 field_0x1019[0x101c - 0x1019]; | ||
| /* 0x101C */ u8 field_0x101c; | ||
| /* 0x101D */ u8 field_0x101d[0x1020 - 0x101d]; |
Contributor
There was a problem hiding this comment.
Can field_0x101d be removed?
src/d/actor/d_a_npc_kolin.cpp
Outdated
| (void*)NULL, | ||
| (void*)__dt__13daNpcT_Path_cFv, | ||
| }; | ||
| draw(FALSE, FALSE, mRealShadowSize, NULL, 100.0f, FALSE, FALSE, FALSE); |
hatal175
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.