Merged
Conversation
Report for GZ2E01 (8b93a87 - 343a0f8)📈 Matched code: 77.47% (+0.14%, +15648 bytes) ✅ 41 new matches
...and 11 more new matches 📈 1 improvement in unmatched functions
|
TakaRikka
reviewed
Aug 14, 2025
src/d/actor/d_a_e_hp.cpp
Outdated
| }; | ||
| #pragma pop | ||
| static dCcD_SrcCyl cc_hp_src = {{ | ||
| {0, {{0x0, 0x0, 0x0}, {(s32)0xd8000000, 0x3}, 0x0}}, |
Contributor
There was a problem hiding this comment.
are these s32 casts actually necessary? also formatting should be fixed if possible
Contributor
Author
There was a problem hiding this comment.
In this case it fixes an "error" in CLion due to the field expecting a signed integer (which 0xd8000000 overflows).
hatal175
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d_a_e_hpis almost matching with this PR. There's a small mismatch inexecuteDeaddue to someg_dComIfG_gameInfoweirdness, and as usualsetMidnaBindEffectstrikes again to mess up function order.This PR also includes a couple of miscellaneous fixes including some changes to allow debug to build successfully.