Merged
Conversation
Contributor
|
does this break other JSystem TUs when included? i feel like if theres a pch then it was probably in all TUs rather than just a few |
Contributor
Author
|
@TakaRikka It doesn't seem to break anything - I've gone through and added it to all JSystem TUs. |
Contributor
|
is this a real build issue or an issue with the cache |
Contributor
Author
|
Somehow the PCH ended up unstaged when I amended the commit - should be fixed now. |
TakaRikka
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
JSystem.pchwhich fixes weak function order/removes the need fornosyminlinein several JSystem TUs. These changes are deliberately conservative and both the PCHand the files that include itare as narrowly scoped as possible to fix existing function order issues.This approach admittedly feels a little ad hoc, so I'm very open to feedback if it seems like this is just being treated as a nail for the PCH hammer when it shouldn't.