Skip to content

Minor d_a_alink improvements#2646

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:d_a_alink-2
Sep 11, 2025
Merged

Minor d_a_alink improvements#2646
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:d_a_alink-2

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented Sep 11, 2025

This PR includes fixes for some remaining d_a_alink mismatches.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Sep 11, 2025

Report for ShieldD (84eed3e - 0e0bf56)

📈 Matched code: 18.98% (+0.00%, +124 bytes)

✅ 1 new match
Unit Function Bytes Before After
framework/d/actor/d_a_alink daObjCrope_c::getStartRate(const cXyz*) +25 80.19% 100.00%
📈 10 improvements in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::setWolfChainPos() +220 85.36% 99.23%
framework/d/actor/d_a_alink daAlink_c::setWolfRopePosY() +170 62.51% 94.50%
framework/d/actor/d_a_alink daAlink_c::changeLink(int) +136 94.50% 98.92%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeMove() +91 94.22% 98.72%
framework/d/actor/d_a_alink daAlink_c::wolfFootBgCheck() +81 88.98% 91.89%
framework/d/actor/d_a_alink daAlink_c::wolfBgCheck() +60 96.65% 99.59%
framework/d/actor/d_a_alink daAlink_c::setHookshotPos() +35 95.16% 95.88%
framework/d/actor/d_a_alink daAlink_c::setDamagePoint(int, int, int, int) +9 89.68% 91.64%
framework/d/actor/d_a_alink daAlink_c::setCrawlMoveDirectionArrow() +8 66.62% 69.06%
framework/d/actor/d_a_alink daAlink_c::procWolfLieMoveInit(int) +5 97.47% 98.60%
📉 2 regressions in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::procCutTurnInit(int, int) -11 99.64% 98.09%
framework/d/actor/d_a_alink daAlink_c::initShadowScaleLight() -3 95.93% 95.68%

Report for GZ2P01 (84eed3e - 0e0bf56)

📈 Matched code: 81.74% (+0.19%, +22388 bytes)

✅ 13 new matches
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::setWolfRopePosY() +66 90.93% 100.00%
framework/d/actor/d_a_alink daAlink_c::setWolfChainPos() +44 97.86% 100.00%
framework/d/actor/d_a_alink daAlink_c::setCrawlMoveDirectionArrow() +14 96.14% 100.00%
framework/d/actor/d_a_alink daAlink_c::wolfFootBgCheck() +14 99.39% 100.00%
framework/d/actor/d_a_alink daAlink_c::initShadowScaleLight() +10 99.01% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeMove() +7 99.75% 100.00%
framework/d/actor/d_a_alink daAlink_c::setStartProcInit() +5 99.79% 100.00%
framework/d/actor/d_a_alink daAlink_c::setHookshotPos() +5 99.93% 100.00%
framework/d/actor/d_a_alink daAlink_c::setDamagePoint(int, int, int, int) +4 99.14% 100.00%
framework/d/actor/d_a_alink daAlink_c::wolfBgCheck() +4 99.82% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeStagger() +3 99.88% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeSubjectivity() +3 99.80% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfLieMoveInit(int) +2 99.77% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::jointControll(int) +1 99.95% 99.96%
framework/d/actor/d_a_alink daAlink_c::changeLink(int) 0 99.80% 99.82%

Report for GZ2J01 (84eed3e - 0e0bf56)

📈 Matched code: 81.41% (+0.19%, +22388 bytes)

✅ 13 new matches
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::setWolfRopePosY() +66 90.93% 100.00%
framework/d/actor/d_a_alink daAlink_c::setWolfChainPos() +44 97.86% 100.00%
framework/d/actor/d_a_alink daAlink_c::setCrawlMoveDirectionArrow() +14 96.14% 100.00%
framework/d/actor/d_a_alink daAlink_c::wolfFootBgCheck() +14 99.39% 100.00%
framework/d/actor/d_a_alink daAlink_c::initShadowScaleLight() +10 99.01% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeMove() +7 99.75% 100.00%
framework/d/actor/d_a_alink daAlink_c::setStartProcInit() +5 99.79% 100.00%
framework/d/actor/d_a_alink daAlink_c::setHookshotPos() +5 99.93% 100.00%
framework/d/actor/d_a_alink daAlink_c::setDamagePoint(int, int, int, int) +4 99.14% 100.00%
framework/d/actor/d_a_alink daAlink_c::wolfBgCheck() +4 99.82% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeStagger() +3 99.88% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeSubjectivity() +3 99.80% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfLieMoveInit(int) +2 99.77% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::jointControll(int) +1 99.95% 99.96%
framework/d/actor/d_a_alink daAlink_c::changeLink(int) 0 99.80% 99.82%

Report for GZ2E01 (84eed3e - 0e0bf56)

📈 Matched code: 83.59% (+0.19%, +22388 bytes)

✅ 13 new matches
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::setWolfRopePosY() +66 90.93% 100.00%
framework/d/actor/d_a_alink daAlink_c::setWolfChainPos() +44 97.86% 100.00%
framework/d/actor/d_a_alink daAlink_c::setCrawlMoveDirectionArrow() +14 96.14% 100.00%
framework/d/actor/d_a_alink daAlink_c::wolfFootBgCheck() +14 99.39% 100.00%
framework/d/actor/d_a_alink daAlink_c::initShadowScaleLight() +10 99.01% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeMove() +7 99.75% 100.00%
framework/d/actor/d_a_alink daAlink_c::setStartProcInit() +5 99.79% 100.00%
framework/d/actor/d_a_alink daAlink_c::setHookshotPos() +5 99.93% 100.00%
framework/d/actor/d_a_alink daAlink_c::setDamagePoint(int, int, int, int) +4 99.14% 100.00%
framework/d/actor/d_a_alink daAlink_c::wolfBgCheck() +4 99.82% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeStagger() +3 99.88% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfRopeSubjectivity() +3 99.80% 100.00%
framework/d/actor/d_a_alink daAlink_c::procWolfLieMoveInit(int) +2 99.77% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_alink daAlink_c::jointControll(int) +1 99.95% 99.96%
framework/d/actor/d_a_alink daAlink_c::changeLink(int) 0 99.80% 99.82%

@TakaRikka TakaRikka merged commit 4b729b0 into zeldaret:main Sep 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants