Skip to content

npc_tkj done#2647

Merged
hatal175 merged 1 commit intozeldaret:mainfrom
TakaRikka:npctkj
Sep 12, 2025
Merged

npc_tkj done#2647
hatal175 merged 1 commit intozeldaret:mainfrom
TakaRikka:npctkj

Conversation

@TakaRikka
Copy link
Copy Markdown
Contributor

@TakaRikka TakaRikka commented Sep 11, 2025

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Sep 11, 2025

Report for GZ2P01 (4b729b0 - f853f9f)

📈 Matched code: 81.84% (+0.10%, +11732 bytes)

✅ 73 new matches
Unit Function Bytes Before After
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::cutLv7Start(int) +1108 0.36% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::daNpcT_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +1025 0.39% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::~daNpcT_c() +900 0.44% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::create() +709 0.56% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::CreateHeap() +656 0.61% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAttnPos() +585 0.68% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleX(cXyz, float, short) +516 0.77% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::talk(void*) +500 0.79% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::wait(void*) +433 0.92% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::reset() +296 1.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleY(cXyz, short, int, float, short) +280 1.41% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setParam() +265 1.49% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::~daNpcT_JntAnm_c() +248 1.59% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtTalk() +225 1.75% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtCutProc() +225 1.75% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setCollision() +221 1.79% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::~daNpcTkj_c() +209 28.70% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAction(int (daNpcTkj_c::*)(void*)) +165 2.38% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::Draw() +152 2.56% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::action() +133 2.94% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj __sinit_d_a_npc_tkj_cpp +133 2.94% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::daNpcTkj_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +125 27.42% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::beforeMove() +117 3.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAfterTalkMotion() +93 4.17% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::ctrlJointCallBack(J3DJoint*, int) +85 4.55% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::selectAction() +76 5.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj J3DTexNoAnm::~J3DTexNoAnm() +69 5.56% 100.00%

...and 43 more new matches

Report for GZ2J01 (4b729b0 - f853f9f)

📈 Matched code: 81.51% (+0.10%, +11732 bytes)

✅ 73 new matches
Unit Function Bytes Before After
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::cutLv7Start(int) +1108 0.36% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::daNpcT_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +1025 0.39% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::~daNpcT_c() +900 0.44% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::create() +709 0.56% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::CreateHeap() +656 0.61% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAttnPos() +585 0.68% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleX(cXyz, float, short) +516 0.77% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::talk(void*) +500 0.79% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::wait(void*) +433 0.92% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::reset() +296 1.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleY(cXyz, short, int, float, short) +280 1.41% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setParam() +265 1.49% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::~daNpcT_JntAnm_c() +248 1.59% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtTalk() +225 1.75% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtCutProc() +225 1.75% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setCollision() +221 1.79% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::~daNpcTkj_c() +209 28.70% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAction(int (daNpcTkj_c::*)(void*)) +165 2.38% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::Draw() +152 2.56% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::action() +133 2.94% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj __sinit_d_a_npc_tkj_cpp +133 2.94% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::daNpcTkj_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +125 27.42% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::beforeMove() +117 3.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAfterTalkMotion() +93 4.17% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::ctrlJointCallBack(J3DJoint*, int) +85 4.55% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::selectAction() +76 5.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj J3DTexNoAnm::~J3DTexNoAnm() +69 5.56% 100.00%

...and 43 more new matches

Report for GZ2E01 (4b729b0 - f853f9f)

📈 Matched code: 83.69% (+0.10%, +11732 bytes)
📈 Linked code: 50.70% (+0.10%, +11864 bytes)

✅ 73 new matches
Unit Function Bytes Before After
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::cutLv7Start(int) +1108 0.36% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::daNpcT_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +1025 0.39% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::~daNpcT_c() +900 0.44% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::create() +709 0.56% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::CreateHeap() +656 0.61% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAttnPos() +585 0.68% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleX(cXyz, float, short) +516 0.77% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::talk(void*) +500 0.79% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::wait(void*) +433 0.92% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::reset() +296 1.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleY(cXyz, short, int, float, short) +280 1.41% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setParam() +265 1.49% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::~daNpcT_JntAnm_c() +248 1.59% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtTalk() +225 1.75% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtCutProc() +225 1.75% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setCollision() +221 1.79% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::~daNpcTkj_c() +209 28.70% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAction(int (daNpcTkj_c::*)(void*)) +165 2.38% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::Draw() +152 2.56% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::action() +133 2.94% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj __sinit_d_a_npc_tkj_cpp +133 2.94% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::daNpcTkj_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +125 27.42% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::beforeMove() +117 3.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dBgS_AcchCir::~dBgS_AcchCir() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dBgS_ObjAcch::~dBgS_ObjAcch() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAfterTalkMotion() +93 4.17% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dCcD_GStts::~dCcD_GStts() +89 4.35% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::ctrlJointCallBack(J3DJoint*, int) +85 4.55% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::selectAction() +76 5.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj J3DTexNoAnm::~J3DTexNoAnm() +69 5.56% 100.00%

...and 43 more new matches

Report for ShieldD (4b729b0 - f853f9f)

📈 Matched code: 19.01% (+0.02%, +3584 bytes)

✅ 35 new matches
Unit Function Bytes Before After
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::daNpcT_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +436 0.91% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::daNpcT_JntAnm_c() +336 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::wait(void*) +296 1.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtTalk() +209 1.89% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_c::initialize() +180 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAction(int (daNpcTkj_c::*)(void*)) +165 2.38% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::ctrlJointCallBack(J3DJoint*, int) +149 2.63% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::action() +144 2.70% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setMode(int, int) +140 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::Delete() +117 3.33% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::daNpcTkj_c(const daNpcT_faceMotionAnmData_c*, const daNpcT_motionAnmData_c*, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int, const daNpcT_evtData_c*, char**) +113 31.32% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::reset() +109 3.57% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_MotionSeqMngr_c::daNpcT_MotionSeqMngr_c(const daNpcT_MotionSeqMngr_c::sequenceStepData_c*, int) +88 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_DmgStagger_c::daNpcT_DmgStagger_c() +76 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::beforeMove() +73 5.26% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_MatAnm_c::daNpcT_MatAnm_c() +72 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::lookNone(unsigned char) +72 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::lookPlayer(unsigned char) +72 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_ActorMngr_c::daNpcT_ActorMngr_c() +64 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::getFlowNodeNo() +57 6.67% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::chkAction(int (daNpcTkj_c::*)(void*)) +57 6.67% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj cCcD_ObjHitInf::SetCoSPrm(unsigned long) +52 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dComIfGp_event_chkTalkXY() +48 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::Execute() +36 10.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj dComIfGp_evmng_ChkPresentEnd() +36 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setDirect(unsigned char) +36 0.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpc_Tkj_Create(void*) +36 10.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpc_Tkj_Delete(void*) +36 10.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpc_Tkj_Execute(void*) +36 10.00% 100.00%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpc_Tkj_Draw(void*) +36 10.00% 100.00%

...and 5 more new matches

📈 20 improvements in unmatched functions
Unit Function Bytes Before After
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::cutLv7Start(int) +926 0.43% 99.82%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::create() +801 0.47% 95.30%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::CreateHeap() +583 0.65% 94.57%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAttnPos() +580 0.63% 91.69%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::talk(void*) +406 0.87% 89.05%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setParam() +226 1.20% 69.48%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleY(cXyz, short, int, float, short) +222 1.14% 64.10%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::evtCutProc() +220 1.79% 99.95%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setCollision() +209 1.54% 82.12%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_JntAnm_c::setEyeAngleX(cXyz, float, short) +200 1.25% 63.88%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::Draw() +176 1.64% 73.38%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcT_DmgStagger_c::initialize() +136 0.00% 89.82%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::~daNpcTkj_c() +116 39.98% 91.18%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::selectAction() +88 2.70% 62.16%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::getType() +83 4.00% 87.40%
d_a_npc_tkj/d/actor/d_a_npc_tkj __sinit_\d_a_npc_tkj_cpp +79 0.00% 74.07%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::setAfterTalkMotion() +67 4.35% 76.70%
d_a_npc_tkj/d/actor/d_a_npc_tkj dEvt_control_c::chkTalkXY() +55 0.00% 43.22%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::getPath() +47 0.00% 91.92%
d_a_npc_tkj/d/actor/d_a_npc_tkj daNpcTkj_c::createHeapCallBack(fopAc_ac_c*) +36 7.69% 75.38%

@caseif
Copy link
Copy Markdown
Contributor

caseif commented Sep 11, 2025

This matches for JP as well.

@hatal175 hatal175 merged commit 8a3a6d2 into zeldaret:main Sep 12, 2025
4 checks passed
@TakaRikka TakaRikka deleted the npctkj branch November 28, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hatal175 hatal175 hatal175 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TakaRikka @caseif @hatal175