Skip to content

Minor JSystem/Z2Audio fixes#2650

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:jsystem-fixup
Sep 12, 2025
Merged

Minor JSystem/Z2Audio fixes#2650
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:jsystem-fixup

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented Sep 12, 2025

This PR includes some minor fixes for JSystem and Z2Audio.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Sep 12, 2025

Report for ShieldD (a6c3c20 - fe82b53)

📈 Matched code: 18.99% (+0.01%, +1168 bytes)

✅ 5 new matches
Unit Function Bytes Before After
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock8::initialize() +480 0.83% 100.00%
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock16::initialize() +480 0.83% 100.00%
framework/JSystem/JAudio2/JASTrack JASTrack::TList::seqMain() +53 81.03% 100.00%
framework/JSystem/J2DGraph/J2DMaterialFactory J2DTexCoord::J2DTexCoord(const J2DTexCoord&) +12 0.00% 100.00%
framework/JSystem/J2DGraph/J2DMaterialFactory J2DColorChan::J2DColorChan(const J2DColorChan&) +12 0.00% 100.00%
💔 1 broken match
Unit Function Bytes Before After
framework/Z2AudioLib/Z2LinkMgr Z2SoundHandles::stopSound(JAISoundID, unsigned long) -17 100.00% 83.80%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/JSystem/J2DGraph/J2DMaterialFactory J2DMaterialFactory::create(J2DMaterial*, int, unsigned long, J2DResReference*, J2DResReference*, JKRArchive*) const +90 95.46% 98.51%
framework/JSystem/J2DGraph/J2DMaterialFactory J2DTexGenBlock::setTexCoord(unsigned long, const J2DTexCoord*) +57 0.00% 27.17%
📉 2 regressions in unmatched functions
Unit Function Bytes Before After
framework/Z2AudioLib/Z2LinkMgr Z2LinkSoundStarter::startSound(JAISoundID, JAISoundHandle*, const JGeometry::TVec3<float>*, unsigned long, float, float, float, float, float, unsigned long) -21 57.40% 56.85%
framework/JSystem/JAudio2/JAUSectionHeap JAUSection::newVoiceBank(unsigned long, unsigned long) -4 99.98% 99.17%

Report for GZ2P01 (a6c3c20 - fe82b53)

📈 Matched code: 81.78% (+0.05%, +5380 bytes)

✅ 5 new matches
Unit Function Bytes Before After
framework/JSystem/JAudio2/JAUSectionHeap JAUSection::newVoiceBank(unsigned long, unsigned long) +13 95.68% 100.00%
framework/Z2AudioLib/Z2LinkMgr Z2CreatureLink::startLinkSound(JAISoundID, unsigned long, signed char) +6 99.22% 100.00%
framework/JSystem/JMessage/processor JMessage::TProcessor::toMessageCode_messageID(unsigned long, unsigned long, bool*) const +3 99.21% 100.00%
framework/JSystem/J2DGraph/J2DMaterialFactory J2DMaterialFactory::create(J2DMaterial*, int, unsigned long, J2DResReference*, J2DResReference*, JKRArchive*) const +2 99.94% 100.00%
framework/Z2AudioLib/Z2LinkMgr Z2LinkSoundStarter::startSound(JAISoundID, JAISoundHandle*, const JGeometry::TVec3<float>*, unsigned long, float, float, float, float, float, unsigned long) +1 99.97% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock8::initialize() +543 0.64% 87.15%
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock16::initialize() +543 0.64% 87.15%

Report for GZ2J01 (a6c3c20 - fe82b53)

📈 Matched code: 81.46% (+0.05%, +5380 bytes)
📈 Linked code: 47.25% (+0.14%, +15532 bytes)

✅ 5 new matches
Unit Function Bytes Before After
framework/JSystem/JAudio2/JAUSectionHeap JAUSection::newVoiceBank(unsigned long, unsigned long) +13 95.68% 100.00%
framework/Z2AudioLib/Z2LinkMgr Z2CreatureLink::startLinkSound(JAISoundID, unsigned long, signed char) +6 99.22% 100.00%
framework/JSystem/JMessage/processor JMessage::TProcessor::toMessageCode_messageID(unsigned long, unsigned long, bool*) const +3 99.21% 100.00%
framework/JSystem/J2DGraph/J2DMaterialFactory J2DMaterialFactory::create(J2DMaterial*, int, unsigned long, J2DResReference*, J2DResReference*, JKRArchive*) const +2 99.94% 100.00%
framework/Z2AudioLib/Z2LinkMgr Z2LinkSoundStarter::startSound(JAISoundID, JAISoundHandle*, const JGeometry::TVec3<float>*, unsigned long, float, float, float, float, float, unsigned long) +1 99.97% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock8::initialize() +543 0.64% 87.15%
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock16::initialize() +543 0.64% 87.15%

Report for GZ2E01 (a6c3c20 - fe82b53)

📈 Matched code: 83.63% (+0.05%, +5380 bytes)
📈 Linked code: 50.79% (+0.14%, +15532 bytes)

✅ 5 new matches
Unit Function Bytes Before After
framework/JSystem/JAudio2/JAUSectionHeap JAUSection::newVoiceBank(unsigned long, unsigned long) +13 95.68% 100.00%
framework/Z2AudioLib/Z2LinkMgr Z2CreatureLink::startLinkSound(JAISoundID, unsigned long, signed char) +6 99.22% 100.00%
framework/JSystem/JMessage/processor JMessage::TProcessor::toMessageCode_messageID(unsigned long, unsigned long, bool*) const +3 99.21% 100.00%
framework/JSystem/J2DGraph/J2DMaterialFactory J2DMaterialFactory::create(J2DMaterial*, int, unsigned long, J2DResReference*, J2DResReference*, JKRArchive*) const +2 99.94% 100.00%
framework/Z2AudioLib/Z2LinkMgr Z2LinkSoundStarter::startSound(JAISoundID, JAISoundHandle*, const JGeometry::TVec3<float>*, unsigned long, float, float, float, float, float, unsigned long) +1 99.97% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock8::initialize() +543 0.64% 87.15%
framework/JSystem/J2DGraph/J2DMatBlock J2DTevBlock16::initialize() +543 0.64% 87.15%

@TakaRikka TakaRikka merged commit 8420c94 into zeldaret:main Sep 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants