Skip to content

Improve several almost-matching TUs#2653

Merged
hatal175 merged 1 commit intozeldaret:mainfrom
caseif:misc-5
Sep 13, 2025
Merged

Improve several almost-matching TUs#2653
hatal175 merged 1 commit intozeldaret:mainfrom
caseif:misc-5

Conversation

@caseif
Copy link
Copy Markdown
Contributor

@caseif caseif commented Sep 13, 2025

This PR includes various improvements for TUs which were almost matching.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Sep 13, 2025

Report for ShieldD (4c9ce97 - b913d23)

📈 Matched code: 19.05% (+0.01%, +1308 bytes)

✅ 5 new matches
Unit Function Bytes Before After
d_a_obj_volcball/d/actor/d_a_obj_volcball daObjVolcBall_c::actionEruption() +54 93.85% 100.00%
framework/d/actor/d_a_grass daPy_py_c::getSwordTopPos() const +45 14.54% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkChangeJoint(int) +13 36.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkRemoveJoint(int) +13 36.00% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::talk(void*) +9 97.64% 100.00%
📈 9 improvements in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_grass dGrass_packet_c::draw() +303 80.20% 88.69%
framework/d/actor/d_a_grass dFlower_packet_c::draw() +118 83.69% 87.02%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::CreateHeap() +101 86.43% 99.99%
d_a_npc_midp/d/actor/d_a_npc_midp __sinit_\d_a_npc_midp_cpp +35 38.57% 69.64%
framework/d/actor/d_a_grass dFlower_packet_c::calc() +26 89.11% 93.06%
d_a_npc_ne/d/actor/d_a_npc_ne useHeapInit(fopAc_ac_c*) +18 98.13% 99.99%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::wait(void*) +13 98.17% 99.07%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::reset() +3 91.55% 92.21%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::setAttnPos() +2 89.24% 89.65%
📉 1 regression in unmatched functions
Unit Function Bytes Before After
framework/d/actor/d_a_grass dGrass_packet_c::calc() -66 78.60% 73.57%

Report for GZ2P01 (4c9ce97 - b913d23)

📈 Matched code: 82.09% (+0.06%, +6712 bytes)

✅ 13 new matches
Unit Function Bytes Before After
d_a_npc_midp/d/actor/d_a_npc_midp __sinit_d_a_npc_midp_cpp +60 42.31% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::reset() +43 90.49% 100.00%
d_a_grass/d/actor/d_a_grass dGrass_packet_c::calc() +33 97.31% 100.00%
d_a_grass/d/actor/d_a_grass daPy_py_c::getSwordTopPos() const +28 0.00% 100.00%
d_a_grass/d/actor/d_a_grass dFlower_packet_c::calc() +14 97.50% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_Param_c::~daNpc_midP_Param_c() +12 83.33% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::wait(void*) +10 99.48% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::talk(void*) +5 99.16% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkChangeJoint(int) +4 75.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkRemoveJoint(int) +4 75.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::setAttnPos() +3 99.58% 100.00%
d_a_obj_volcball/d/actor/d_a_obj_volcball daObjVolcBall_c::actionEruption() +3 99.75% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::CreateHeap() +2 99.82% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
d_a_grass/d/actor/d_a_grass dFlower_packet_c::draw() +79 96.84% 99.98%
d_a_grass/d/actor/d_a_grass dGrass_packet_c::draw() +71 97.33% 99.99%

Report for GZ2E01 (4c9ce97 - b913d23)

📈 Matched code: 83.98% (+0.10%, +11904 bytes)
📈 Linked code: 51.60% (+0.32%, +37028 bytes)

✅ 15 new matches
Unit Function Bytes Before After
d_a_grass/d/actor/d_a_grass dFlower_packet_c::draw() +79 96.85% 100.00%
d_a_grass/d/actor/d_a_grass dGrass_packet_c::draw() +72 97.34% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp __sinit_d_a_npc_midp_cpp +60 42.31% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::reset() +43 90.49% 100.00%
d_a_grass/d/actor/d_a_grass dGrass_packet_c::calc() +33 97.31% 100.00%
d_a_grass/d/actor/d_a_grass daPy_py_c::getSwordTopPos() const +28 0.00% 100.00%
d_a_grass/d/actor/d_a_grass dFlower_packet_c::calc() +14 97.50% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_Param_c::~daNpc_midP_Param_c() +12 83.33% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::wait(void*) +10 99.48% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::talk(void*) +5 99.16% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkChangeJoint(int) +4 75.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkRemoveJoint(int) +4 75.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::setAttnPos() +3 99.58% 100.00%
d_a_obj_volcball/d/actor/d_a_obj_volcball daObjVolcBall_c::actionEruption() +3 99.75% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::CreateHeap() +2 99.82% 100.00%

Report for GZ2J01 (4c9ce97 - b913d23)

📈 Matched code: 81.77% (+0.06%, +6948 bytes)
📈 Linked code: 48.06% (+0.55%, +63040 bytes)

✅ 14 new matches
Unit Function Bytes Before After
d_a_npc_midp/d/actor/d_a_npc_midp __sinit_d_a_npc_midp_cpp +60 42.31% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::reset() +43 90.49% 100.00%
d_a_grass/d/actor/d_a_grass dGrass_packet_c::calc() +33 97.31% 100.00%
d_a_grass/d/actor/d_a_grass daPy_py_c::getSwordTopPos() const +28 0.00% 100.00%
d_a_grass/d/actor/d_a_grass dFlower_packet_c::calc() +14 97.50% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_Param_c::~daNpc_midP_Param_c() +12 83.33% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::wait(void*) +10 99.48% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::talk(void*) +5 99.16% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkChangeJoint(int) +4 75.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::checkRemoveJoint(int) +4 75.00% 100.00%
d_a_npc_midp/d/actor/d_a_npc_midp daNpc_midP_c::setAttnPos() +3 99.58% 100.00%
d_a_obj_volcball/d/actor/d_a_obj_volcball daObjVolcBall_c::actionEruption() +3 99.75% 100.00%
d_a_npc_saru/d/actor/d_a_npc_saru daNpc_Saru_c::CreateHeap() +2 99.82% 100.00%
d_a_obj_volcball/d/actor/d_a_obj_volcball daObjVolcBall_c::action() +1 99.83% 100.00%
📈 2 improvements in unmatched functions
Unit Function Bytes Before After
d_a_grass/d/actor/d_a_grass dFlower_packet_c::draw() +79 96.84% 99.98%
d_a_grass/d/actor/d_a_grass dGrass_packet_c::draw() +71 97.33% 99.99%

@YunataSavior
Copy link
Copy Markdown
Contributor

Closes #695, Closes #845, Closes #667

@hatal175 hatal175 merged commit dbbd102 into zeldaret:main Sep 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants