Conversation
Report for Shield (95c3626 - c898211)📈 1 improvement in an unmatched item
Report for GZ2P01 (95c3626 - c898211)No changesReport for GZ2E01 (95c3626 - c898211)No changesReport for RZDP01 (95c3626 - c898211)No changesReport for RZDJ01 (95c3626 - c898211)No changesReport for GZ2J01 (95c3626 - c898211)No changesReport for ShieldD (95c3626 - c898211)No changesReport for RZDE01_02 (95c3626 - c898211)No changesReport for DZDE01 (95c3626 - c898211)No changesReport for RZDE01_00 (95c3626 - c898211)No changes |
Contributor
Author
|
As a thought, instead of all these macros, I could instead replace the macros with typedefs, something like |
Contributor
|
i prefer the macros personally |
Contributor
Author
|
Do you think there are too many casts in this pr? I replaced all the |
TakaRikka
reviewed
Feb 3, 2026
TakaRikka
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through and cleaned up a lot of the s16 casts, but let me know if I went a little overboard. I tried to differentiate s16s from angles, don't know how necessary that was, but it was easier to fix as I went along.