Skip to content

Fix a bunch of compiler warnings and document several more bugs#3130

Merged
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:compile-warning-fixes
Mar 18, 2026
Merged

Fix a bunch of compiler warnings and document several more bugs#3130
TakaRikka merged 1 commit intozeldaret:mainfrom
caseif:compile-warning-fixes

Conversation

@caseif
Copy link
Contributor

@caseif caseif commented Mar 14, 2026

This PR fixes numerous compiler warnings, mostly when building with Clang, as well as some UB. I've also added a bunch more !@bug comments for bugs that were previously undocumented.

@decomp-dev
Copy link

decomp-dev bot commented Mar 14, 2026

Report for RZDP01 (9f340b6 - eecab0a)

No changes

Report for Shield (9f340b6 - eecab0a)

No changes

Report for GZ2J01 (9f340b6 - eecab0a)

No changes

Report for RZDJ01 (9f340b6 - eecab0a)

No changes

Report for RZDE01_00 (9f340b6 - eecab0a)

No changes

Report for RZDE01_02 (9f340b6 - eecab0a)

No changes

Report for GZ2P01 (9f340b6 - eecab0a)

No changes

Report for GZ2E01 (9f340b6 - eecab0a)

No changes

Report for DZDE01 (9f340b6 - eecab0a)

No changes

Report for ShieldD (9f340b6 - eecab0a)

📈 Matched code: 53.96% (+0.00%, +56 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_shop_system daTag_ShopItem_c::getFlowNodeNum() +56 0.00% 100.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_shop_system dShopSystem_c::searchItemActor() +54 86.05% 89.09%
d_a_obj_brg/d/actor/d_a_obj_brg obj_brg_move(obj_brg_class*) +4 96.37% 96.47%
framework/d/d_msg_object dMsgObject_c::getSmellTypeMessageIDLocal() +2 84.76% 86.19%

@caseif caseif force-pushed the compile-warning-fixes branch 3 times, most recently from a9a4b83 to 6cd4a58 Compare March 14, 2026 22:25
@caseif caseif force-pushed the compile-warning-fixes branch from 6cd4a58 to dcac840 Compare March 18, 2026 00:55
@caseif caseif force-pushed the compile-warning-fixes branch from dcac840 to eecab0a Compare March 18, 2026 00:56
@TakaRikka TakaRikka merged commit 6694c1b into zeldaret:main Mar 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants