various d_bg debug cleanup / d_menu_window_HIO debug by TakaRikka · Pull Request #3132 · zeldaret/tp

TakaRikka · 2026-03-17T09:49:36Z

No description provided.

decomp-dev · 2026-03-17T09:53:31Z

Report for RZDP01 (`ae0f890` - `152ac54`)

📈 Matched code: 53.29% (+0.06%, +6000 bytes)

✅ 8 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_s_acch`	`dBgS_Acch::CalcWallBmdCyl()`	+105	59.71%	100.00%
`framework/d/d_bg_w`	`cM3dGPla::getCrossY_NonIsZero(const cXyz&) const`	+52	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::RwgWallCorrect(dBgS_Acch*, unsigned short)`	+38	98.17%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectSort(dBgS_Acch*)`	+38	98.11%	100.00%
`framework/d/d_bg_s`	`cBgS::GetTriPla(const cBgS_PolyInfo&, cM3dGPla*) const`	+37	74.94%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CrrPos(dBgS&)`	+34	97.11%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::GroundRoofProc(dBgS&)`	+24	88.18%	100.00%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Typical(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+20	83.45%	100.00%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrectSort(dBgS_Acch*)`	+38	92.42%	93.50%
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrect(dBgS_Acch*)`	+37	97.55%	98.82%
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+3	92.50%	92.88%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+2	99.73%	99.96%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+2	78.04%	78.27%

Report for Shield (`ae0f890` - `152ac54`)

📈 Matched code: 50.26% (+0.01%, +1096 bytes)

✅ 5 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w`	`dBgW::WallCorrectGrpRp(dBgS_Acch*, int, int)`	+215	26.62%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrect(dBgS_Acch*)`	+12	0.00%	100.00%
`framework/d/d_bg_w`	`cBgW::GroundCrossRp(cBgS_GndChk*, int)`	+8	99.14%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CalcWallBmdCyl()`	+4	98.55%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CrrPos(dBgS&)`	+2	99.89%	100.00%

🥀 3 broken matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w`	`cBgW::LineCheckRp(cBgS_LinChk*, int)`	-631	100.00%	37.25%
`framework/d/d_bg_w`	`dBgW::SplGrpChkRp(dBgS_SplGrpChk*, int)`	-232	100.00%	55.22%
`framework/d/d_bg_w`	`dBgW::RoofChkRp(dBgS_RoofChk*, int)`	-231	100.00%	54.99%

📈 3 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+3	95.87%	96.22%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+2	99.76%	99.98%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+2	98.42%	98.66%

Report for RZDE01_02 (`ae0f890` - `152ac54`)

📈 Matched code: 54.49% (+0.06%, +6000 bytes)

✅ 8 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_s_acch`	`dBgS_Acch::CalcWallBmdCyl()`	+105	59.71%	100.00%
`framework/d/d_bg_w`	`cM3dGPla::getCrossY_NonIsZero(const cXyz&) const`	+52	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::RwgWallCorrect(dBgS_Acch*, unsigned short)`	+38	98.17%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectSort(dBgS_Acch*)`	+38	98.11%	100.00%
`framework/d/d_bg_s`	`cBgS::GetTriPla(const cBgS_PolyInfo&, cM3dGPla*) const`	+37	74.94%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CrrPos(dBgS&)`	+34	97.11%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::GroundRoofProc(dBgS&)`	+24	88.18%	100.00%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Typical(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+20	83.45%	100.00%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrectSort(dBgS_Acch*)`	+38	92.42%	93.50%
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrect(dBgS_Acch*)`	+37	97.55%	98.82%
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+3	92.50%	92.88%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+2	99.73%	99.96%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+2	78.04%	78.27%

Report for GZ2J01 (`ae0f890` - `152ac54`)

No changes

Report for GZ2E01 (`ae0f890` - `152ac54`)

No changes

Report for ShieldD (`ae0f890` - `152ac54`)

📈 Matched code: 53.96% (+0.46%, +67676 bytes)
📈 Matched data: 54.12% (+0.27%, +11060 bytes)

✅ 258 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_menu_window_HIO`	`dMw_HIO_c::genMessage(JORMContext*)`	+7744	0.00%	100.00%
`framework/d/d_bg_w`	`.data`	+5452	29.09%	100.00%
`framework/d/d_bg_s`	`dBgS_HIO::genMessage(JORMContext*)`	+3624	0.00%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_HIO_c::itemBitCheck()`	+2572	0.00%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_HIO_c::itemHIO()`	+2504	0.00%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_HIO_c::playerStatusHIO()`	+1856	0.00%	100.00%
`framework/d/d_bg_s`	`dBgS_InsideHIO::genMessage(JORMContext*)`	+1796	0.00%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_DHIO_c::bitCheck()`	+1652	0.00%	100.00%
`framework/d/d_bg_s_spl_grp_chk`	`.data`	+1007	22.30%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_DHIO_c::genMessage(JORMContext*)`	+840	0.00%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_HIO_c::itemNumHIO()`	+752	0.00%	100.00%
`framework/d/d_bg_w`	`cBgW::GlobalVtx()`	+649	22.08%	100.00%
`framework/d/d_bg_s_spl_grp_chk`	`dBgS_SplGrpChk::Set(cXyz&, float)`	+635	8.27%	100.00%
`framework/d/d_bg_w`	`cBgW::RwgLineCheck(unsigned short, cBgS_LinChk*)`	+534	37.96%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::DrawWall(dBgS&)`	+516	0.00%	100.00%
`framework/d/d_bg_s`	`dBgS_AabDraw(cM3dGAab&, _GXColor&)`	+504	0.00%	100.00%
`framework/d/d_bg_s`	`poly_draw(dBgS_CaptPoly, cBgD_Vtx_t, int, int, int, cM3dGPla*)`	+420	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::DrawBox() const`	+416	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::DebugDraw() const`	+384	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::DrawPoly(const cBgS_PolyInfo&, const _GXColor&) const`	+384	0.00%	100.00%
`framework/d/d_bg_s`	`cBgS::Regist(dBgW_Base, unsigned int, void)`	+331	42.60%	100.00%
`framework/d/d_bg_s`	`dBgS::Ct()`	+304	10.88%	100.00%
`framework/d/d_bg_w`	`cBgW::GetGrpRoomIndex(const cBgS_PolyInfo&) const`	+262	37.15%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectRp(dBgS_Acch*, int)`	+262	58.17%	100.00%
`framework/d/d_bg_s`	`dBgS::CaptPoly(dBgS_CaptPoly&)`	+260	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectRpSort(dBgS_Acch*, int)`	+260	54.23%	100.00%
`framework/d/d_bg_w`	`dBgW::SplGrpChkRp(dBgS_SplGrpChk*, int)`	+250	59.05%	100.00%
`framework/d/d_bg_w`	`dBgW::RoofChkRp(dBgS_RoofChk*, int)`	+249	59.05%	100.00%
`framework/d/d_bg_w`	`cBgW::GroundCrossRp(cBgS_GndChk*, int)`	+248	64.59%	100.00%
`framework/d/d_menu_window_HIO`	`dMw_HIO_c::init()`	+247	79.36%	100.00%

...and 228 more new matches

📈 26 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_bg_s`	`.data`	+3556	3.76%	98.52%
`framework/d/d_menu_window_HIO`	`.data`	+3162	1.48%	97.88%
`framework/d/d_bg_s`	`dBgS::Draw()`	+1319	0.00%	99.10%
`framework/d/d_bg_s`	`.bss`	+486	0.00%	85.71%
`framework/d/d_bg_s`	`cBgS::ConvDzb(void*)`	+448	31.92%	92.79%
`framework/d/d_bg_w`	`cBgW::CalcPlane()`	+376	35.25%	88.88%
`framework/d/d_bg_s`	`white_draw(dBgS_CaptPoly, cBgD_Vtx_t, int, int, int, cM3dGPla*)`	+372	0.00%	87.86%
`framework/d/d_menu_window_HIO`	`.sdata`	+269	7.11%	93.39%
`framework/d/d_bg_s`	`.sdata`	+218	13.86%	96.26%
`framework/d/d_bg_s_movebg_actor`	`dBgS_MoveBgActor::MoveBGCreate(const char, int, void ()(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz), unsigned long, float()[3][4])`	+115	68.77%	98.28%
`framework/d/d_bg_s`	`dBgS::MoveBgCrrPos(const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*, bool, bool)`	+109	62.98%	91.01%
`framework/d/d_bg_s`	`dBgS::MoveBgTransPos(const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+107	56.01%	89.17%
`framework/d/d_bg_s`	`dBgS::MoveBgMatrixCrrPos(const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+106	53.38%	88.39%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Typical(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+80	50.61%	99.51%
`framework/d/d_bg_w`	`dBgW::RwgWallCorrect(dBgS_Acch*, unsigned short)`	+45	98.81%	99.97%
`framework/d/d_bg_w`	`dBgW::WallCorrectSort(dBgS_Acch*)`	+45	98.78%	99.97%
`framework/d/d_bg_s`	`.sbss`	+38	18.18%	97.30%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_RotY(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+36	52.58%	80.21%
`framework/d/d_bg_w`	`dBgW::ChkGrpThrough(int, cBgS_GrpPassChk*, int)`	+35	79.04%	96.57%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Trans(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+28	65.69%	89.97%
`d_a_obj_brg/d/actor/d_a_obj_brg`	`ride_call_back(dBgW, fopAc_ac_c, fopAc_ac_c*)`	+26	95.71%	98.44%
`framework/d/d_bg_w_kcol`	`dBgWKCol::CaptPoly(dBgS_CaptPoly&)`	+12	98.32%	99.12%
`framework/d/d_bg_w_kcol`	`.data`	+6	98.04%	98.24%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+5	99.55%	99.92%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+4	90.87%	91.32%
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+4	97.07%	97.70%

Report for RZDE01_00 (`ae0f890` - `152ac54`)

📈 Matched code: 46.84% (+0.06%, +6000 bytes)

✅ 8 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_s_acch`	`dBgS_Acch::CalcWallBmdCyl()`	+105	59.71%	100.00%
`framework/d/d_bg_w`	`cM3dGPla::getCrossY_NonIsZero(const cXyz&) const`	+52	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::RwgWallCorrect(dBgS_Acch*, unsigned short)`	+38	98.17%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectSort(dBgS_Acch*)`	+38	98.11%	100.00%
`framework/d/d_bg_s`	`cBgS::GetTriPla(const cBgS_PolyInfo&, cM3dGPla*) const`	+37	74.94%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CrrPos(dBgS&)`	+34	97.11%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::GroundRoofProc(dBgS&)`	+24	88.18%	100.00%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Typical(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+20	83.45%	100.00%

📈 6 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrectSort(dBgS_Acch*)`	+38	92.42%	93.50%
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrect(dBgS_Acch*)`	+37	97.55%	98.82%
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+3	92.50%	92.88%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+2	99.73%	99.96%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+2	78.04%	78.27%
`d_a_obj_brg/d/actor/d_a_obj_brg`	`ride_call_back(dBgW, fopAc_ac_c, fopAc_ac_c*)`	0	99.14%	99.15%

Report for RZDJ01 (`ae0f890` - `152ac54`)

📈 Matched code: 53.67% (+0.06%, +6000 bytes)

✅ 8 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_s_acch`	`dBgS_Acch::CalcWallBmdCyl()`	+105	59.71%	100.00%
`framework/d/d_bg_w`	`cM3dGPla::getCrossY_NonIsZero(const cXyz&) const`	+52	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::RwgWallCorrect(dBgS_Acch*, unsigned short)`	+38	98.17%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectSort(dBgS_Acch*)`	+38	98.11%	100.00%
`framework/d/d_bg_s`	`cBgS::GetTriPla(const cBgS_PolyInfo&, cM3dGPla*) const`	+37	74.94%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CrrPos(dBgS&)`	+34	97.11%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::GroundRoofProc(dBgS&)`	+24	88.18%	100.00%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Typical(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+20	83.45%	100.00%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrectSort(dBgS_Acch*)`	+38	92.42%	93.50%
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrect(dBgS_Acch*)`	+37	97.55%	98.82%
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+3	92.50%	92.88%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+2	99.73%	99.96%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+2	78.04%	78.27%

Report for DZDE01 (`ae0f890` - `152ac54`)

📈 Matched code: 52.08% (+0.06%, +6000 bytes)

✅ 8 new matches

Unit	Item	Bytes	Before	After
`framework/d/d_bg_s_acch`	`dBgS_Acch::CalcWallBmdCyl()`	+105	59.71%	100.00%
`framework/d/d_bg_w`	`cM3dGPla::getCrossY_NonIsZero(const cXyz&) const`	+52	0.00%	100.00%
`framework/d/d_bg_w`	`dBgW::RwgWallCorrect(dBgS_Acch*, unsigned short)`	+38	98.17%	100.00%
`framework/d/d_bg_w`	`dBgW::WallCorrectSort(dBgS_Acch*)`	+38	98.11%	100.00%
`framework/d/d_bg_s`	`cBgS::GetTriPla(const cBgS_PolyInfo&, cM3dGPla*) const`	+37	74.94%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::CrrPos(dBgS&)`	+34	97.11%	100.00%
`framework/d/d_bg_s_acch`	`dBgS_Acch::GroundRoofProc(dBgS&)`	+24	88.18%	100.00%
`framework/d/d_bg_s`	`dBgS_MoveBGProc_Typical(dBgW, void, const cBgS_PolyInfo&, bool, cXyz, csXyz, csXyz*)`	+20	83.45%	100.00%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrectSort(dBgS_Acch*)`	+38	92.42%	93.50%
`framework/d/d_bg_w_kcol`	`dBgWKCol::WallCorrect(dBgS_Acch*)`	+37	97.55%	98.82%
`framework/d/d_meter2`	`dMeter2_c::movePachinkoNum()`	+3	92.50%	92.88%
`framework/d/d_meter2`	`dMeter2_c::moveBombNum()`	+2	99.73%	99.96%
`framework/d/d_meter2`	`dMeter2_c::moveArrowNum()`	+2	78.04%	78.27%

Report for GZ2P01 (`ae0f890` - `152ac54`)

No changes

TakaRikka added 2 commits March 17, 2026 02:46

various d_bg debug cleanup

f6f89ad

matching forward decl for compiler compatibility

8f5c812

fix build

152ac54

TakaRikka merged commit 9f340b6 into zeldaret:main Mar 17, 2026
10 checks passed

TakaRikka deleted the miscdebug branch March 18, 2026 05:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

various d_bg debug cleanup / d_menu_window_HIO debug#3132

various d_bg debug cleanup / d_menu_window_HIO debug#3132
TakaRikka merged 3 commits intozeldaret:mainfrom
TakaRikka:miscdebug

TakaRikka commented Mar 17, 2026

Uh oh!

decomp-dev bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

TakaRikka commented Mar 17, 2026

Uh oh!

decomp-dev bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for RZDP01 (ae0f890 - 152ac54)

Report for Shield (ae0f890 - 152ac54)

Report for RZDE01_02 (ae0f890 - 152ac54)

Report for GZ2J01 (ae0f890 - 152ac54)

No changes

Report for GZ2E01 (ae0f890 - 152ac54)

No changes

Report for ShieldD (ae0f890 - 152ac54)

Report for RZDE01_00 (ae0f890 - 152ac54)

Report for RZDJ01 (ae0f890 - 152ac54)

Report for DZDE01 (ae0f890 - 152ac54)

Report for GZ2P01 (ae0f890 - 152ac54)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

decomp-dev bot commented Mar 17, 2026 •

edited

Loading

Report for RZDP01 (`ae0f890` - `152ac54`)

Report for Shield (`ae0f890` - `152ac54`)

Report for RZDE01_02 (`ae0f890` - `152ac54`)

Report for GZ2J01 (`ae0f890` - `152ac54`)

Report for GZ2E01 (`ae0f890` - `152ac54`)

Report for ShieldD (`ae0f890` - `152ac54`)

Report for RZDE01_00 (`ae0f890` - `152ac54`)

Report for RZDJ01 (`ae0f890` - `152ac54`)

Report for DZDE01 (`ae0f890` - `152ac54`)

Report for GZ2P01 (`ae0f890` - `152ac54`)