Open
Conversation
Collaborator
|
Any update on this? FYI, the TU doesn't need to be 100% for you to mark it as "ready for review". |
Contributor
Author
ah sorry, got busy with other things. I made a lot of progress on this, I think it was mostly just down to regalloc stuff. I'll do a bit of cleanup and then open it up for review |
Report for D44J01 (27f0df1 - 1672534)📈 Matched code: 42.17% (+0.17%, +13012 bytes) ✅ 118 new matches
...and 88 more new matches 📈 12 improvements in unmatched functions
Report for GZLE01 (27f0df1 - 1672534)📈 Matched code: 54.38% (+0.19%, +14728 bytes) ✅ 120 new matches
...and 90 more new matches 📈 11 improvements in unmatched functions
Report for GZLP01 (27f0df1 - 1672534)📈 Matched code: 53.00% (+0.19%, +14728 bytes) ✅ 120 new matches
...and 90 more new matches 📈 11 improvements in unmatched functions
Report for GZLJ01 (27f0df1 - 1672534)📈 Matched code: 53.09% (+0.19%, +14716 bytes) ✅ 120 new matches
...and 90 more new matches 📈 11 improvements in unmatched functions
|
ross3102
commented
Oct 29, 2025
Comment on lines
+2135
to
+2146
| // static int bmd_data[8] = { | ||
| // MT_BDL_MG_HEAD, MT_BDL_MG_BODY, MT_BDL_MG_BODY, MT_BDL_MG_BODY, | ||
| // MT_BDL_MG_BODY, MT_BDL_MG_BODY, MT_BDL_MG_BODY, MT_BDL_MG_TAIL | ||
| // }; | ||
|
|
||
| // static f32 scale_data[8] = { | ||
| // 1.0f, 1.0f, 1.0f, 0.975f, 0.925f, 0.825f, 0.75f, 0.525f | ||
| // }; | ||
|
|
||
| // static int br_bmd[3] = { | ||
| // MT_BDL_KBA, MT_BDL_KBB, MT_BDL_KBC | ||
| // }; |
Contributor
Author
There was a problem hiding this comment.
these seem to be in .data twice for some reason?
Comment on lines
+2232
to
+2237
| const char* unused[4] = { | ||
| "i_this->btk[i]", | ||
| "i_this->brk[i]", | ||
| "i_this->br_modelL[i] != 0", | ||
| "i_this->br_modelR[i] != 0" | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
these strings are in .rodata even though they're not used anywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
94% .data
98% .text