d_a_obj_msdan2 by RedArms · Pull Request #919 · zeldaret/tww

RedArms · 2026-01-06T03:40:45Z

Decompile the objet from issue #425

decomp-dev · 2026-01-06T03:42:17Z

Report for D44J01 (`ba4a7b4` - `8047968`)

📈 Matched code: 44.55% (+0.00%, +284 bytes)
📈 Matched data: 41.23% (+0.00%, +95 bytes)

✅ 5 new matches

Unit	Item	Bytes	Before	After
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Execute()`	+244	1.61%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+80	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e)`	+28	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Delete()`	+4	50.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+1	99.00%	100.00%

📈 1 improvement in unmatched functions

Unit	Item	Bytes	Before	After
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Create()`	+463	0.85%	99.91%

Report for GZLP01 (`ba4a7b4` - `8047968`)

📈 Matched code: 55.22% (+0.01%, +752 bytes)
📈 Linked code: 36.08% (+0.01%, +864 bytes)
📈 Matched data: 46.37% (+0.00%, +95 bytes)
📈 Linked data: 41.82% (+0.00%, +95 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Create()`	+464	0.85%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Execute()`	+244	1.61%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+80	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e)`	+28	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Delete()`	+4	50.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+1	99.00%	100.00%

Report for GZLE01 (`ba4a7b4` - `8047968`)

📈 Matched code: 56.96% (+0.01%, +752 bytes)
📈 Linked code: 36.92% (+0.01%, +864 bytes)
📈 Matched data: 47.80% (+0.00%, +95 bytes)
📈 Linked data: 41.96% (+0.00%, +95 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Create()`	+464	0.85%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Execute()`	+244	1.61%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+80	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e)`	+28	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Delete()`	+4	50.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+1	99.00%	100.00%

Report for GZLJ01 (`ba4a7b4` - `8047968`)

📈 Matched code: 55.27% (+0.01%, +752 bytes)
📈 Linked code: 36.94% (+0.01%, +864 bytes)
📈 Matched data: 46.16% (+0.00%, +95 bytes)
📈 Linked data: 40.93% (+0.00%, +95 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Create()`	+464	0.85%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Execute()`	+244	1.61%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+80	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e)`	+28	0.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`daObjMsdan2::Act_c::Mthd_Delete()`	+4	50.00%	100.00%
`d_a_obj_msdan2/d/actor/d_a_obj_msdan2`	`.data`	+1	99.00%	100.00%

src/d/actor/d_a_obj_msdan2.cpp

configure.py

src/d/actor/d_a_obj_msdan2.cpp

RedArms · 2026-01-09T00:51:29Z

I think the a-style and prm_get_swSave inline is mandatory for the 100% code

What do you think ?
EDIT: We were not seeing the %^^

LagoLunatic · 2026-01-09T18:00:30Z

I think the a-style and prm_get_swSave inline is mandatory for the 100% code

I doubt it, that's just regalloc. The cause of that is probably something else and the cast you added was a fakematch. Have you tried posting a scratch with the regalloc in the discord and asking for help?

RedArms · 2026-01-12T21:25:54Z

It should be good now

src/d/actor/d_a_obj_msdan2.cpp

include/d/actor/d_a_obj_msdan2.h

src/d/actor/d_a_obj_msdan2.cpp

LagoLunatic

You keep making a lot of random changes, apparently by mistake? Unlike the previous ones these last two don't really matter or affect anything, but can you please look at your own changes to be sure they're correct before you commit them? Most of your commits have these odd changes in them.

LagoLunatic · 2026-01-12T23:35:31Z

src/d/actor/d_a_obj_msdan2.cpp

+#include "d/d_a_obj.h"

-/* 00000078-0000024C       .text Mthd_Create__Q211daObjMsdan25Act_cFv */
+/* 00000078-000003D4       .text Mthd_Create__Q211daObjMsdan25Act_cFv */


Again, same comment is still wrong.

include/d/actor/d_a_obj_search.h

RedArms added 3 commits January 6, 2026 04:30

Decompile d_a_obj_msdan2

e8fb03d

Fix and cleaning

ca0f23d

Forgot to add .h

699b235

LagoLunatic reviewed Jan 6, 2026

View reviewed changes

RedArms added 2 commits January 12, 2026 21:37

Decompile d_a_obj_msdan2

bf9b715

Fix all

cde8c50

LagoLunatic reviewed Jan 12, 2026

View reviewed changes

Correct some mistakes

81dc101

LagoLunatic reviewed Jan 12, 2026

View reviewed changes

include/d/actor/d_a_obj_msdan2.h Outdated Show resolved Hide resolved

src/d/actor/d_a_obj_msdan2.cpp Outdated Show resolved Hide resolved

Correct some other mistakes

90bbdfa

LagoLunatic reviewed Jan 12, 2026

View reviewed changes

deleted the line

8047968

Conversation

RedArms commented Jan 6, 2026

Uh oh!

decomp-dev bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for D44J01 (ba4a7b4 - 8047968)

Report for GZLP01 (ba4a7b4 - 8047968)

Report for GZLE01 (ba4a7b4 - 8047968)

Report for GZLJ01 (ba4a7b4 - 8047968)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RedArms commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LagoLunatic commented Jan 9, 2026

Uh oh!

RedArms commented Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LagoLunatic left a comment

Choose a reason for hiding this comment

Uh oh!

LagoLunatic Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

decomp-dev bot commented Jan 6, 2026 •

edited

Loading

Report for D44J01 (`ba4a7b4` - `8047968`)

Report for GZLP01 (`ba4a7b4` - `8047968`)

Report for GZLE01 (`ba4a7b4` - `8047968`)

Report for GZLJ01 (`ba4a7b4` - `8047968`)

RedArms commented Jan 9, 2026 •

edited

Loading