Open
Conversation
Lord-McSweeney
commented
Jan 14, 2026
| } else { | ||
| cXyz local_60 = dStack_74.getPoint(mPointIndex2); | ||
| cXyz local_6c = dStack_74.getPoint(mPointIndex1); | ||
| s16 sVar4 = cLib_targetAngleY(¶m_1->current.pos, &link_actor->current.pos); |
Contributor
Author
There was a problem hiding this comment.
I think this is missing an inline, but I'm not sure which one it is
Report for GZLP01 (9cc61c4 - ebfb151)📈 Matched code: 55.27% (+0.06%, +4456 bytes) ✅ 14 new matches
Report for GZLE01 (9cc61c4 - ebfb151)📈 Matched code: 57.00% (+0.06%, +4456 bytes) ✅ 14 new matches
Report for D44J01 (9cc61c4 - ebfb151)📈 Matched code: 44.56% (+0.02%, +1172 bytes) ✅ 8 new matches
📈 6 improvements in unmatched functions
Report for GZLJ01 (9cc61c4 - ebfb151)📈 Matched code: 55.32% (+0.06%, +4456 bytes) ✅ 14 new matches
|
Lord-McSweeney
force-pushed
the
d_a_npc_mk_static
branch
from
2badf98 to
ebfb151
Compare
Lord-McSweeney
commented
Jan 14, 2026
| cLib_addCalcAngleS(¶m_1->current.angle.y, local_48, 8, 0x800, 0x200); | ||
| } | ||
|
|
||
| f32 cosine = JMASCos(param_1->current.angle.y - local_48); |
Contributor
Author
There was a problem hiding this comment.
I'm not sure whether this and the other JMASCos call should be changed to cM_scos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.