d_a_obj_gnndemotakis

[jaysc]

Issue: #400

I started this without realising there was an old PR here: #862
Huge thanks to @Xxj2211 as It helped a lot.

Hopefully next time I can do one entirely myself.

---

Todo:

create_heap

Some reason it's not matching fully. Trying to figure out why.

[decomp-dev]

Report for GZLE01 (55a6be8 - 9fc25b8)

📈 Matched code: 61.04% (+0.02%, +1300 bytes)
📈 Matched data: 49.27% (+0.01%, +210 bytes)

✅ 11 new matches

Unit	Item	Bytes	Before	After
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::create_heap()	+345	1.15%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_execute()	+276	1.43%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_create()	+272	1.45%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_draw()	+117	3.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.rodata	+106	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_btkAnm::~mDoExt_btkAnm()	+92	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_baseAnm::~mDoExt_baseAnm()	+72	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_delete()	+45	8.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::solidHeapCB(fopAc_ac_c*)	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::init_mtx()	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.data	+25	76.15%	100.00%

---

Report for GZLJ01 (55a6be8 - 9fc25b8)

📈 Matched code: 59.14% (+0.02%, +1300 bytes)
📈 Matched data: 47.63% (+0.01%, +210 bytes)

✅ 11 new matches

Unit	Item	Bytes	Before	After
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::create_heap()	+345	1.15%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_execute()	+276	1.43%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_create()	+272	1.45%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_draw()	+117	3.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.rodata	+106	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_btkAnm::~mDoExt_btkAnm()	+92	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_baseAnm::~mDoExt_baseAnm()	+72	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_delete()	+45	8.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::solidHeapCB(fopAc_ac_c*)	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::init_mtx()	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.data	+25	76.15%	100.00%

---

Report for D44J01 (55a6be8 - 9fc25b8)

📈 Matched code: 49.38% (+0.01%, +676 bytes)
📈 Matched data: 42.83% (+0.01%, +210 bytes)

✅ 9 new matches

Unit	Item	Bytes	Before	After
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_create()	+276	1.43%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_draw()	+117	3.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.rodata	+106	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_btkAnm::~mDoExt_btkAnm()	+92	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_baseAnm::~mDoExt_baseAnm()	+72	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_delete()	+45	8.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::solidHeapCB(fopAc_ac_c*)	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::init_mtx()	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.data	+25	76.15%	100.00%

📈 2 improvements in unmatched items

Unit	Item	Bytes	Before	After
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::create_heap()	+343	1.15%	99.60%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_execute()	+274	1.39%	96.32%

---

Report for GZLP01 (55a6be8 - 9fc25b8)

📈 Matched code: 59.08% (+0.02%, +1300 bytes)
📈 Matched data: 47.81% (+0.01%, +210 bytes)

✅ 11 new matches

Unit	Item	Bytes	Before	After
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::create_heap()	+345	1.15%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_execute()	+276	1.43%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_create()	+272	1.45%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_draw()	+117	3.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.rodata	+106	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_btkAnm::~mDoExt_btkAnm()	+92	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	mDoExt_baseAnm::~mDoExt_baseAnm()	+72	0.00%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::_delete()	+45	8.33%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::solidHeapCB(fopAc_ac_c*)	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	daObjGnntakis_c::init_mtx()	+28	12.50%	100.00%
d_a_obj_gnndemotakis/d/actor/d_a_obj_gnndemotakis	.data	+25	76.15%	100.00%

[LagoLunatic]

Some reason it's not matching fully. Trying to figure out why.

That looks like an objdiff bug, it seems to already match. Which version of objdiff are you using? If it's an old one update to the latest version.

Also, try linking it to see if it actually matches or not, regardless of what objdiff says.