Skip to content

fix: Fix bookmark toolbar flickering when in sidebar-only mode #11272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+25 −3
Open

fix: Fix bookmark toolbar flickering when in sidebar-only mode #11272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/zen/tabs/zen-tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,12 @@

/* Include styles for the top bar under certain conditions:
* - Bookmarks toolbar is visible OR
* - The container is explicitly marked to hide controls (e.g., on Linux with reversed controls)
* - The container is explicitly marked to hide controls (e.g., on Linux with reversed controls) OR
* - Sidebar is on the left (to prevent flash when toggling bookmarks)
*/
:root[zen-has-bookmarks] &,
&[should-hide='true'] {
&[should-hide='true'],
:root:not([zen-right-side='true']) & {
%include zen-tabs/vertical-tabs-topbar.inc.css
}

Expand All @@ -49,6 +51,7 @@
pointer-events: none !important;
}
}

}


Expand Down
21 changes: 20 additions & 1 deletion src/zen/tabs/zen-tabs/vertical-tabs-topbar.inc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
height: var(--zen-toolbar-height);
z-index: 1;

& .zen-toolbar-background {
display: flex;
}

#zen-appcontent-navbar-container {
display: flex;
min-height: var(--zen-toolbar-height);
Expand All @@ -22,7 +26,8 @@ z-index: 1;

%include ../../compact-mode/windows-captions-fix-active.inc.css

&:not([zen-has-hover='true']):not([has-popup-menu]):not([zen-compact-mode-active]) {
&:not([zen-has-hover='true']):not([has-popup-menu]):not([zen-compact-mode-active]),
:root:not([zen-right-side='true']):not([zen-has-bookmarks]) & {
height: var(--zen-element-separation);
opacity: 0;
& #zen-appcontent-navbar-container {
Expand All @@ -41,3 +46,17 @@ z-index: 1;
}
}
}

/* When sidebar is on left, position contents absolutely to overlay on hover */
:root:not([zen-right-side='true']) & {
/* Keep wrapper in flow to reserve space, but position contents absolutely */
position: relative;

& #zen-appcontent-navbar-container {
position: absolute;
top: 0;
left: 0;
right: 0;
z-index: 10;
}
}