no-bug: A few quality-of-life tweaks (build tooling)#13565
Conversation
| } | ||
| } | ||
|
|
||
| fn is_twilight_build() -> bool { |
There was a problem hiding this comment.
Is this being used correctly? As the DIR might be different?
There was a problem hiding this comment.
Hm, I missed that relative-to-$CWD dir. It's effectively a third (if optional) input.
I've pushed an update to package.json that will run ffprefs in the top-level directory, instead of cd'ing down into tools/ffprefs/.
package.json: Use the $CARGO environment variable if set, and pass arguments to ffprefs using the new convention (see below) update_service_dumps.py: Allow specifying DUMPS_FOLDER and ENGINE_DUMPS_FOLDER on the command line ffprefs/src/main.rs: Allow specifying the prefs and engine dirs on the command line instead of hard-coding their locations relative to a common root dir
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks! I put in a companion PR for Surfer, along similar lines. |
|
fails to run |
|
Hm, I wasn't aware this needed to run on Windows. The I see there are some solutions to running OS-specific scripts in a |
Hello, I am using some of the Zen build tools in an alternate setting, a framework that "converts" a Debian source package of Firefox into the equivalent Zen one. To that end, having some additional flexibility in the invocation of the tooling is helpful.
package.json: Use the$CARGOenvironment variable if set, and pass arguments toffprefsusing the new convention (see below)(E.g. on Ubuntu, there is generally not a
cargoexecutable inPATH, but there may be acargo-1.91. This is normally specified via theCARGOvariable, similar toCCandCXX)update_service_dumps.py: Allow specifyingDUMPS_FOLDERandENGINE_DUMPS_FOLDERon the command lineffprefs/src/main.rs: Allow specifying the prefs and engine dirs on the command line instead of hard-coding their locations relative to a common root dir