Skip to content

gh-13653: fix copy url button/shortcut to respect decodeURLsOnCopy spec #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashvwinn wants to merge 7 commits into
base: dev
Choose a base branch
from
+25 −2
Open

gh-13653: fix copy url button/shortcut to respect decodeURLsOnCopy spec #13659

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99448b5
fix copy url button/shortcut not respecting `decodeURLsOnCopy` spec
ashvwinn May 11, 2026
f7a1788
refactor decode uri condition with checks for data uri
ashvwinn May 12, 2026
d5faeec
Merge branch 'dev' into decode-urls-on-copy
ashvwinn May 12, 2026
c57f409
remove comments
ashvwinn May 12, 2026
5d2ae7b
handle decodeURI error
ashvwinn May 12, 2026
332cacf
Merge branch 'dev' into decode-urls-on-copy
mr-cheffy May 13, 2026
3bee6eb
fix linter issues
ashvwinn May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/zen/common/modules/ZenCommonUtils.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,17 @@ export class nsZenPreloadedFeature {

window.gZenCommonActions = {
copyCurrentURLToClipboard() {
const [currentUrl, ClipboardHelper] = gURLBar.zenStrippedURI;
let [currentUrl, ClipboardHelper] = gURLBar.zenStrippedURI;
const displaySpec = currentUrl.displaySpec;
ClipboardHelper.copyString(displaySpec);

// copy decoded URI if `browser.urlbar.decodeURLsOnCopy` is enabled
let decodeURLsOnCopy = Services.prefs.getBoolPref('browser.urlbar.decodeURLsOnCopy', false);
if (decodeURLsOnCopy) {
ClipboardHelper.copyString(decodeURI(displaySpec));
} else {
ClipboardHelper.copyString(displaySpec);
}

let button;
/* eslint-disable mozilla/valid-services */
if (Services.zen.canShare() && displaySpec.startsWith("http")) {
Expand Down Expand Up @@ -118,7 +126,16 @@ window.gZenCommonActions = {
copyCurrentURLAsMarkdownToClipboard() {
const [currentUrl, ClipboardHelper] = gURLBar.zenStrippedURI;
const tabTitle = gBrowser.selectedTab.label;
const markdownLink = `[${tabTitle}](${currentUrl.displaySpec})`;
let markdownLink;

// copy decoded URI if `browser.urlbar.decodeURLsOnCopy` is enabled
let decodeURLsOnCopy = Services.prefs.getBoolPref('browser.urlbar.decodeURLsOnCopy', false);
if (decodeURLsOnCopy) {
markdownLink = `[${tabTitle}](${currentUrl.displaySpec})`;
} else {
markdownLink = `[${tabTitle}](${decodeURI(currentUrl.displaySpec)})`;
}

ClipboardHelper.copyString(markdownLink);
gZenUIManager.showToast("zen-copy-current-url-as-markdown-confirmation", {
timeout: 3000,
Expand Down