no-bug: Add keyboard shortcuts to move tabs between workspaces#13668
Open
kristof-nyr wants to merge 2 commits into
Open
no-bug: Add keyboard shortcuts to move tabs between workspaces#13668kristof-nyr wants to merge 2 commits into
kristof-nyr wants to merge 2 commits into
Conversation
Signed-off-by: Kristof Nyari <nyari.kristof66@gmail.com>
Signed-off-by: Kristof Nyari <nyari.kristof66@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 12 new keyboard shortcuts to move the active (or multiselected) tabs to a specific workspace or to the next/previous workspace.
Addresses community requests in:
What's included
<command>elements inzen-commands.inc.xhtmlshortcutMoveTabTo(index)andmoveActiveTabShortcut(offset)in
ZenSpaceManager.mjs; empty tabs (zen-empty-tab) are filtered out toprevent moving placeholder tabs
[name]") using existing
gZenUIManager.showToast; the toast container's ARIAlive region provides screenreader announcements automatically
ZenKeyboardShortcuts.mjswith migration toversion 19; extracted shared
createMoveTabShortcuts()factory so fresh-installand migration paths cannot diverge
unbound on other platforms
same-workspace guard, empty-tab fallback, and toast verification
Design decisions
When using "change tab(s) to workspace" to send tabs to another workspace it should not switch the workspace #1058 consensus)
pattern)
Behavioral note for reviewers
In
zen-sets.js, thedefaultcase was reordered: workspace-switch andmove-tab commands are now checked before
gZenGlanceManager.handleMainCommandSet().Previously the glance manager saw all default-case commands including workspace
switches. The new order only passes truly unrecognized commands to the glance
manager. This is more correct (workspace commands aren't glance-related) but
reviewers should confirm the glance manager doesn't depend on seeing those events.