gh-14448: fix glance tabs not getting pinned with zen.folders.owned-tabs-in-folder on#14449
Open
ashvwinn wants to merge 6 commits into
Open
gh-14448: fix glance tabs not getting pinned with zen.folders.owned-tabs-in-folder on#14449ashvwinn wants to merge 6 commits into
zen.folders.owned-tabs-in-folder on#14449ashvwinn wants to merge 6 commits into
Conversation
dosubot
Bot
added
size:XS
Member
Author
|
why do we even have these two functions separate btw? can't they be just merged into one. they do the same thing |
ashvwinn
changed the title
zen.folders.owned-tabs-in-folder on
dosubot
Bot
added
size:S
dosubot
Bot
added
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression where expanding/splitting a Glance tab does not correctly apply Zen Folder “owned tabs in folder” behavior when zen.folders.owned-tabs-in-folder is enabled.
Changes:
- Refactors
fullyOpenGlance()to snapshotcurrentTab/currentParentTabbefore closing the glance entry, then applies pinning and tab reordering afterward. - Consolidates folder pinning logic into a single helper and removes the split-only pinning helper.
- Adjusts animation/flag sequencing so
animatingFullOpenis cleared at the end of the full-open flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1640
to
+1644
| this.finishOpeningGlance(); | ||
| this.#handleZenFolderPinning(currentTab, currentParentTab); | ||
| gBrowser.moveTabAfter(currentTab, currentParentTab); | ||
|
|
||
| if (!forSplit && !gReduceMotion) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #14448
regression from #14431