Fix sidebar scroll position reset on fullscreen exit#14493
Open
shaun6jrome wants to merge 1 commit into
Open
Conversation
Adds an inDOMFullscreen guard to #ensureTabIsVisible(), mirroring the existing guard pattern in ZenSpaceManager's onPinnedTabsResize(). Prevents ensureElementIsVisible from running against a transiently-distorted scrollbox layout during fullscreen exit, which was causing the sidebar to snap to the top. Fixes zen-browser#14389
dosubot
Bot
added
size:XS
5 tasks
Member
|
I wonder why this function is getting called in the first place? We shouldn't be calling it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14389
Problem
Sidebar tab scroll position resets to top after exiting fullscreen video, specifically when the new-tab-button is positioned at the bottom of the sidebar. Caused by
_handleTabSelectre-triggering during the fullscreen exit transition, whenarrowScrollbox's layout geometry is still transiently distorted.Fix
Adds an
inDOMFullscreenguard to#ensureTabIsVisible(), matching the existing guard pattern already used inZenSpaceManager'sonPinnedTabsResize()for the same class of fullscreen-transition layout bug.Testing
Submitted from source review — I wasn't able to build and manually test this locally yet due to environment constraints. The fix follows an existing, precedented guard pattern in the codebase for this exact transition. Happy to verify against a running build once my environment is set up, or sooner if a maintainer can confirm the approach.