-
-
Notifications
You must be signed in to change notification settings - Fork 791
Fix a few typos & add CI #7533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix a few typos & add CI #7533
Conversation
It looks good, but I think you should make a seperate workflow for the spell checker aswell. |
Also you can change crate-ci/[email protected] to crate-ci/typos@v1 I think (so we don't need to bump it everytime) |
Proably a bad idea but, when you make this into a seperate workflow, we can make it run weekly or daily (?) and commit them using another action. So we don't need run it manually. |
I wouldn't generally let a typo corrector make direct changes - it might mess up and the code would be invalidated. I'd just use this like a linter where corrections are still manually advised. |
Or make it create a PR maybe? |
Yeah, I'd like to hear what @mauro-balades thinks would be the easiest integration of this tool. |
Have you tested everything works as expected? |
Given that all of these changes are non-functional and just cosmetic - I would imagine everything would work. I can build it myself and attempt to test, but I doubt there would be direct issues related to this. |
Signed-off-by: Jackson <[email protected]>
Ill take a look once I have time, but I for one, never had a good experience with these tools |
Lol |
I noticed there were a few typos and wanted to address them, but think a GitHub Action workflow would likely be better.
This fixes a few typos and adds a typo linter for functions and text within the project. The last commit shows the changes that were made with
typos --exclude "*.min.*" --write-changes
.