Skip to content

Download animation #7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

BrielOtero
Copy link
Contributor

@BrielOtero BrielOtero commented Apr 17, 2025

Core Functionality

  • Detect download start
  • Identify download trigger source:
    • Determine the element/location that initiated the download for animation starting point.
    • Support initiation via standard left-clicks (e.g., clicking a download link/button).
    • Support initiation via the context menu (e.g., "Right-click -> Save Link As...", "Save Image As...").
  • Start the animation
  • Settings Integration: Add an option in the application settings to enable or disable the download animation.

UI/UX & Visuals

  • Find icon that align with the existing 'Zen' style guide.
  • Ensure the animation displays correctly in both standard and compact UI modes.
  • Ensure the animation functions correctly regardless of the position/customization of the browser's download icon
  • Make a good animation

Target (Something near this)

Screen.Recording.2025-04-17.at.17.11.32.mp4

Current state

Screen.Recording.2025-04-17.at.17.21.35.mp4

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature labels Apr 17, 2025
@mauro-balades
Copy link
Member

It should be an unified icon in my opinion, not depending on the file type

@BrielOtero
Copy link
Contributor Author

BrielOtero commented Apr 17, 2025

It should be an unified icon in my opinion, not depending on the file type

Perfect, I'll remove the icons and leave just one. I'm not quite sure what to do when enabling 'Save files', because the browser automatically opens downloads, You can watch it in the current state video.

@BrielOtero BrielOtero marked this pull request as draft April 17, 2025 16:08
@Ahsan-Aziz-Ishan
Copy link

Do we have an option to enable / disable animation ? I think we should have some kind of global rule for disabling animation in Zen, and these implementations can pick that event.

@mauro-balades
Copy link
Member

mauro-balades commented Apr 17, 2025

Having reduced motion would do it. @BrielOtero could you add a config just in case someone wants to disaable it?

@BrielOtero
Copy link
Contributor Author

Having reduced motion would do it. @BrielOtero could you add a config just in case someone wants to disaable it?

@mauro-balades Yes. This is the idea.

@bpavuk
Copy link

bpavuk commented Apr 20, 2025

I don't know if anyone agrees with me, but both Zen and Arc animations are too slow to my taste, I'd make it 1.25x-1.5x faster.

Perhaps, a slider for controlling animation speed would help? I doubt it won't overcomplicate things, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants