Skip to content

feat: improve HTML semantics and buttons animation - #428

Open
SebastianL-dev wants to merge 2 commits into
zen-browser:mainfrom
SebastianL-dev:sebastianl-dev
Open

feat: improve HTML semantics and buttons animation#428
SebastianL-dev wants to merge 2 commits into
zen-browser:mainfrom
SebastianL-dev:sebastianl-dev

Conversation

@SebastianL-dev

Copy link
Copy Markdown
  • Improved HTML semantics and fix buttons hover transition.

@mr-cheffy

Copy link
Copy Markdown
Member

Hi! Could we see how it look now?

@SebastianL-dev

Copy link
Copy Markdown
Author

Hey, the design its the same, i just fixed some HTML semantics, and the buttons transitions its better, before all buttons have no transitions, now have fade transition on hover.

Screen.Recording.2025-01-24.213418.mp4

It's a little change but i think that look much better.

@mr-cheffy

Copy link
Copy Markdown
Member

Doesn't it break the initial animations though?

@SebastianL-dev

Copy link
Copy Markdown
Author

Nope, it doesn't, you can see it in the video 😊

@colinvkim

Copy link
Copy Markdown
Contributor

Hey, nice work! This change seems fine for the most part, but it does break the color of the "Start Exploring" button. On the main version, it's dark (to contrast it from the "Download" button), but on your version, it's light. Shouldn't be too hard to fix.

There might be some other color issues too, but that's the main one that I noticed.

@SebastianL-dev

SebastianL-dev commented Jan 27, 2025

Copy link
Copy Markdown
Author

Hey, sorry for that, i didn't realize about that, i will fix it and update this pull request, thank you. 😊

@SebastianL-dev

Copy link
Copy Markdown
Author
  • Fixed buttons transitions, now looks better and don't break the contrast in buttons.
Screen.Recording.2025-01-27.135619.mp4

Hey, i fixed the transitions, now the transitions looks better and it doesn't break the contrast.

@nocanoa
nocanoa requested a review from mr-cheffy January 31, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants