fix: align release note and ESLint config types#925
Open
Chinay-Domitrix wants to merge 3 commits into
Open
Conversation
Update the ReleaseNote type so security entries can be represented as either a single string or an array, matching the imported release note JSON data.
Cast eslint-plugin-jsx-a11y through ESLint.Plugin where it is registered in the Astro and JSX a11y ESLint configs.
Remove the unused @ts-expect-error now that eslint-plugin-import provides types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few TypeScript typing issues that show up in the current config/data setup.
The release note JSON data can include
securityas either a single entry or an array of entries, so theReleaseNotetype now reflects that instead of only allowingstrings.The ESLint config updates are small type-only cleanups:
eslint-plugin-jsx-a11ythroughESLint.Pluginwhere it is registered@ts-expect-errorfrom theeslint-plugin-importimport now that the package provides typesChanged files:
src/release-notes.ts.eslint/astro.ts.eslint/jsx-a11y.ts.eslint/import.ts