Skip to content

Conversation

@zenangst
Copy link
Owner

@zenangst zenangst commented May 20, 2025

This PR aims to improve the SwiftUI performance by not relying too much on @ViewBuilder and @ObserveInjection. It also fixes some bugs related to keyboard shortcuts and dynamic workspaces.

But the biggest culprit was probably the use of id in the workflow detail, which basically meant that we had to recreate the entire view hierarchy when you selected a new workflow.

  • Remove use of @ViewBuilder & @ObserveInjection and .enableInjection()
  • Add onChange inside the WorkflowInfoView the publisher name changes
  • Remove the use of Group and enableInjection in the detail view
  • Fix updating application triggers
  • Remove animation for the workflow trigger list view
  • Increase the item height of the workflow application triggers
  • Fix bug with keyboard shortcuts not updating properly when switching between workflows
  • Sort dynamic workspace applications based on activity to keep the order when you switch back
  • Unhide apps on dynamic workspaces without tiling
  • Improve focusing on the correct application when using dynamic workspaces & multiple screens
  • Skip delay when tiling is disabled for a dynamic workspace
  • Decrease leader key minimum Disable the modifier trigger controller
  • Fix bug that key trigger modifiers didn't update properly when switching workflows

@github-actions
Copy link

@zenangst zenangst merged commit 147b8a5 into main May 20, 2025
1 check passed
@zenangst zenangst deleted the swiftui/performance branch May 20, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants