Improve SwiftUI performance #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the SwiftUI performance by not relying too much on
@ViewBuilderand@ObserveInjection. It also fixes some bugs related to keyboard shortcuts and dynamic workspaces.But the biggest culprit was probably the use of
idin the workflow detail, which basically meant that we had to recreate the entire view hierarchy when you selected a new workflow.@ViewBuilder&@ObserveInjectionand.enableInjection()onChangeinside the WorkflowInfoView the publisher name changes