Skip to content

feat: Add search for tickets with the search api#280

Closed
Vico1993 wants to merge 1 commit into
victor.piolin/brandsfrom
victor.piolin/search-tickets
Closed

feat: Add search for tickets with the search api#280
Vico1993 wants to merge 1 commit into
victor.piolin/brandsfrom
victor.piolin/search-tickets

Conversation

@Vico1993
Copy link
Copy Markdown
Contributor

Description

This PR introduces a new method searchTickets in the Zendesk API service to search Zendesk tickets based on a query string, with optional sorting and pagination support. The method prepends type:ticket to the query to target tickets specifically. It supports fetching all paginated results or just the first page based on a flag. Corresponding interfaces for search responses and search result items have been added to the Zendesk API models. Comprehensive tests cover the method's behavior including query formation, pagination, and option handling.

How to manually test

  1. Run existing unit tests to confirm coverage of the searchTickets method.
  2. Use the searchTickets method with various query strings and sorting options in the ZendeskApiService.
  3. Verify that the returned tickets match the expected search results from the Zendesk API and pagination behaves correctly.
  4. Check that the query string always includes the type:ticket prefix.

Include label

  • Version: Minor

Acceptation criteria

  • Added the corrected label to my pull request
  • Added/updated tests impacted by the change
  • Documentation is up-to-date (README.md / INSTALL.md)
  • Manually tested?

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...:sweat: The following steps failed:

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@Vico1993 Vico1993 closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant