users by ids#294
Merged
Merged
Conversation
Documents the design for a new ZendeskApiService method to fetch multiple users by IDs using the show_many endpoint, following the pattern established by getZendeskTickets().
Remove .json extension from show_many endpoint to match the pattern used by getZendeskTickets()
Detailed TDD-based plan for adding getUsersByIds method to ZendeskApiService with complete test coverage and step-by-step implementation instructions.
- Retrieves multiple users by IDs using show_many endpoint - Enforces 100-user limit matching getZendeskTickets pattern - Supports generic typing for custom user fields
tristan-vu
requested review from
a team,
Vico1993,
cuneytcelebican and
pol-mampey
as code owners
|
Bump version from 1.5.1 to 1.6.0 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Vico1993
approved these changes
Apr 9, 2026
cuneytcelebican
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds functionality to retrieve multiple Zendesk users by their IDs, with a maximum limit of 100 users per request, and includes comprehensive unit tests to ensure correct behavior. The main changes are grouped into service implementation and test coverage.
Zendesk user retrieval improvements:
getUsersByIdsto theZendeskApiServiceclass, allowing retrieval of up to 100 users by their IDs in a single API call. The method throws an error if more than 100 IDs are provided. (src/services/zendesk-api-service.ts)How to manually test
Include label
We are following this pattern to keep our package version updated. Please add the appropriate label to your Pull requests between the following:
Acceptation criteria