update ICreateTemplateResponse#89
Closed
tristan-vu wants to merge 3 commits into
Closed
Conversation
ref: SCLABS-2488
tristan-vu
requested review from
a team,
Vico1993,
cuneytcelebican and
pol-mampey
as code owners
|
Bump version from 0.2.8 to 0.2.9 |
1 similar comment
|
Bump version from 0.2.8 to 0.2.9 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tristan-vu
changed the title
Vico1993
reviewed
Apr 8, 2025
Contributor
Vico1993
left a comment
Vico1993
left a comment
There was a problem hiding this comment.
Don't forget to update the description of the PR
|
|
||
| export interface ICreateTemplateResponse extends ICreateTemplate { | ||
| export interface ICreateTemplateResponse { | ||
| responseJson: IMessageTemplate; |
Contributor
There was a problem hiding this comment.
Maybe we can remove responseJson from the element we return to the user ?
|
|
||
| export interface ICreateTemplateResponse extends ICreateTemplate { | ||
| export interface ICreateTemplateResponse { | ||
| responseJson: IMessageTemplate; |
Contributor
There was a problem hiding this comment.
Can we make a Generic type for responseJson response type?
tristan-vu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: SCLABS-2488
Description
update ICreateTemplateResponse to include
responseJsonHow to manually test
Include label
We are following this pattern to keep our package version updated. Please add the appropriate label to your Pull requests between the following:
Acceptation criteria