Refactor Side Load of ZendeskAPI::Association Into A Separate Object#555
Open
khezam wants to merge 2 commits into
Open
Refactor Side Load of ZendeskAPI::Association Into A Separate Object#555khezam wants to merge 2 commits into
ZendeskAPI::Association Into A Separate Object#555khezam wants to merge 2 commits into
Conversation
khezam
changed the title
ZendeskAPI::Association Into A Separate Object
Contributor
|
Hi @khezam - thank you for another contribution! (your previous one is coming, I just need another internal review). We don't have much time at present to do a deep review on it, but eventually we'll find the time. First question: Is this code already covered by existing tests or would it benefit from extra testing? Thanks again ❤️ |
Author
|
Hi @ecoologic - my pleasure and I'm happy I could help :)
No worries at all and I totally understand that.
Yes, this code is already covered by existing tests :) |
khezam
force-pushed
the
khezam/refactor_side_load
branch
from
498742a to
6fd2ba6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the side load behaviors of the
ZendeskAPI::Associationclass could be encapsulated in a separate object for extendability so I thought it might be a good opportunity to refactor.Let me know if it's not needed and I'm happy to close this PR.