-
Notifications
You must be signed in to change notification settings - Fork 185
use new account in live specs #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1228c23 to
f3044e5
Compare
| "Wed Feb 01 13:14:15 UTC 2012" | ||
| end | ||
| } | ||
| let(:parsed) { "2012-02-01 13:14:15 UTC" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the live specs change, I just noticed this very old and very unnecessary Ruby version check.
| ``` | ||
|
|
||
| Then `bundle` as usual. | ||
| Then `bundle install` as usual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundle will stop working in Bundler 4.
|
|
||
| [](https://github.com/zendesk/zendesk_api_client_rb/actions/workflows/main.yml?query=branch%3Amaster) | ||
| [](https://badge.fury.io/rb/zendesk_api) | ||
| [](https://codeclimate.com/github/zendesk/zendesk_api_client_rb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn‘t work anymore and I don’t think we need to revive it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 they don’t do open source scans anymore.
| SPEC_LIVE_ZENDESK_HOST: ${{ secrets.SPEC_LIVE_ZENDESK_HOST }} | ||
| SPEC_LIVE_USERNAME: ${{ secrets.SPEC_LIVE_USERNAME_NEW }} | ||
| SPEC_LIVE_PASSWORD: ${{ secrets.SPEC_LIVE_PASSWORD_NEW }} | ||
| SPEC_LIVE_ZENDESK_HOST: ${{ secrets.SPEC_LIVE_ZENDESK_HOST_NEW }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll replace current SPEC_LIVE_USERNAME etc. values and use them again after this PR is approved (and before merging it).
| it_should_be_readable current_user, :assigned_tickets, create: true | ||
| it_should_be_readable agent, :ccd_tickets, create: true | ||
| it_should_be_readable current_user, :assigned_tickets | ||
| it_should_be_readable agent, :ccd_tickets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t full figured out why creation fails now, but we never created these users from here anyway (we create these users and assign and CC tickets during manual setup).
f3044e5 to
067671d
Compare
| def valid_attributes | ||
| { | ||
| :category_id => "3", | ||
| :category_id => "9903501961242", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the category id from the new test account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I don’t know why it worked with an account-specific like "3" before.
Switches to a different test account in live specs (provisioned with Pandora), updates account setup instructions, cleans up a few unrelated things.