update ASP example to support user and org names containing multibyte characters #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good, though indentation needs some love, and I'm not sure if the comments really help here, doesn't really feel like they add anything above/beyond what the code's already doing. |
There was a problem hiding this comment.
This doesn't seem to line up with what's being done in the line above...
1<<12 is 4096 and 224 != 234 :)
Maybe a simple function to help test & sanity check the encoding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, Base64 encoding function in the IIS/AD bundle didn't work for names with multibyte characters. I replaced the contents of the base64.asp utility with the function here and added a UTF-8 encoding function in the AD script itself.
cc: @jcheatham, @morten, @pdeuter