feat(focusvisible): migrate focusvisible to TypeScript - #137
Merged
Conversation
hzhu
changed the title
hzhu
changed the title
hzhu
commented
Nov 13, 2019
hzhu
force-pushed
the
hzhu/focusvisible-typescript
branch
from
November 14, 2019 00:24
e8866b4 to
f592ac3
Compare
hzhu
marked this pull request as ready for review
November 14, 2019 03:20
austingreendev
approved these changes
Nov 14, 2019
austingreendev
left a comment
austingreendev
left a comment
Contributor
There was a problem hiding this comment.
LGTM besides the small comments
hzhu
force-pushed
the
hzhu/focusvisible-typescript
branch
from
November 14, 2019 17:53
9152bac to
e83274e
Compare
hzhu
force-pushed
the
hzhu/focusvisible-typescript
branch
from
November 14, 2019 18:57
8a7653c to
52a1447
Compare
jzempel
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates the
focusvisiblepackage to TypeScript.Checklist
yarn start)