port DataTable functionality from Pro #102
Conversation
kiprasmel
force-pushed
the
port-datatable-from-pro
branch
from
54e2710 to
cfb7131
Compare
kiprasmel
force-pushed
the
port-datatable-from-pro
branch
from
cfb7131 to
1694673
Compare
| sorting={sorting} | ||
| onSortingChange={setSorting} |
There was a problem hiding this comment.
i don't think sorting here actually works. any idea what's missing?
There was a problem hiding this comment.
There is also a useSorting hook involved, that is missing here I think 🤔
There was a problem hiding this comment.
but that hook in pro is only for syncing the sorting state to the router/url. i don't think it's needed here because it's specific for our use case. or did i miss something and it has logic that makes the sorting work?
i checked it again, i see that the state gets set in the url and then taken in & applied. but can't we have the sorting work w/ local state first, instead of putting it in the url? at least for the example here
There was a problem hiding this comment.
Hm, I'm not sure tbh. The difference might be that in Pro were doing server-side sorting, while here you want to rely on client-only sorting https://tanstack.com/table/v8/docs/guide/sorting#client-side-vs-server-side-sorting
There was a problem hiding this comment.
hmm that's tough. because in the storybook demo it's not working at all. i'll take a look at how to fix this, but in the meantime i think we can merge, since it'll work fine in our repos?
| sorting={sorting} | ||
| onSortingChange={setSorting} |
There was a problem hiding this comment.
There is also a useSorting hook involved, that is missing here I think 🤔
kiprasmel
force-pushed
the
port-datatable-from-pro
branch
from
1b28f7f to
2faf23b
Compare
|
sorting to be fixed in the example later |
problems: