Task/3850 show error info #872
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
Adds global snapshots/deployments navigation and improves error visibility, particularly surfacing step exception details in code views and refining deletion UX.
- Highlights step exceptions by line and includes traceback in the Step “Code” tab; centralizes timestamp parsing via prepareBackendTimestamp.
- Introduces global Snapshots/Deployments pages, routes, and tabs; simplifies dropdown/delete flows to consistent AlertDialog usage.
- Cleans up date handling across components and adds a header BackButton.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/router/routes.tsx | Adds overview routes for global snapshots and deployments. |
| src/router/Router.tsx | Wires new routes with lazy page components and PageBoundary. |
| src/lib/timeline/mapping.ts | Uses centralized timestamp parser for step start time. |
| src/lib/dates.ts | Adds prepareBackendTimestamp utility for robust date parsing. |
| src/lib/bulk-delete.tsx | Shows per-item error toasts and adjusts selection after bulk delete. |
| src/layouts/project-tabs/tabs.tsx | Adds Snapshots and Deployments tabs and navigation. |
| src/layouts/AuthenticatedLayout/back-button.tsx | New BackButton component in header. |
| src/layouts/AuthenticatedLayout/AuthenticatedHeader.tsx | Integrates BackButton and reorders breadcrumb imports. |
| src/components/steps/step-sheet/CodeTab.tsx | Passes exception line and traceback to code snippet; includes a debug log. |
| src/components/service-connectors/expiry.tsx | Uses prepareBackendTimestamp for connector expiry. |
| src/components/pipeline-snapshots/table-actions.tsx | Renames actions component for snapshots. |
| src/components/pipeline-snapshots/list/use-queryparams.ts | Renames hook to useSnapshotListQueryParams. |
| src/components/pipeline-snapshots/list/table.tsx | Accepts columns by prop to share definitions. |
| src/components/pipeline-snapshots/list/column-definitions.tsx | Centralizes snapshot column definitions. |
| src/components/logs/log-line.tsx | Formats timestamps via prepareBackendTimestamp and locale string. |
| src/components/dialog/DialogItem.tsx | Removes deprecated DialogItem component. |
| src/components/deployments/list/use-deployment-queryparams.ts | Renames hook to useDeploymentQueryParams. |
| src/components/deployments/list/table.tsx | Accepts columns by prop to share definitions. |
| src/components/deployments/list/column-definitions.tsx | Centralizes deployment column definitions. |
| src/components/breadcrumbs/library.ts | Enables links for Deployments and Snapshots breadcrumbs. |
| src/components/DisplayDate.tsx | Uses prepareBackendTimestamp for display. |
| src/components/DeleteAlertDialog.tsx | Allows disabling Delete button while pending. |
| src/components/CodeSnippet.tsx | Supports exception line highlight and traceback rendering. |
| src/components/AlertDialogDropdownItem.tsx | Removes deprecated AlertDialogItem component. |
| src/app/snapshots/page.tsx | Adds global snapshots page. |
| src/app/snapshots/page.content.tsx | Implements global snapshots content and table wiring. |
| src/app/snapshots/columns.tsx | Column list for global snapshots view. |
| src/app/snapshots/[snapshotId]/_layout/header/breadcrumbs.ts | Uses snapshot breadcrumb link. |
| src/app/settings/service-accounts/[service-account-id]/columns.tsx | Uses prepareBackendTimestamp for “last used” date. |
| src/app/settings/service-accounts/[service-account-id]/Dropdown.tsx | Refactors dropdown to AlertDialog + DropdownMenu. |
| src/app/settings/secrets/[id]/SecretTableDropDown.tsx | Refactors to explicit AlertDialog and button trigger. |
| src/app/settings/secrets/[id]/DeleteKeyAlert.tsx | Uses shared DeleteAlertContent; manages open state externally. |
| src/app/settings/secrets/SecretsDropdown.tsx | Refactors edit/delete to Dialog/AlertDialog usage. |
| src/app/settings/secrets/EditSecretDialog.tsx | Button type fixes and add-key when no fields. |
| src/app/settings/secrets/DeleteSecretAlert.tsx | Uses shared DeleteAlertContent; manages open state externally. |
| src/app/settings/members/MemberDropdown.tsx | Refactors remove flow to AlertDialog + DropdownMenu item. |
| src/app/settings/members/DeleteMemberAlert.tsx | Moves to shared DeleteAlertContent; disables while pending. |
| src/app/runs/RunDropdown.tsx | Refactors delete flow to AlertDialog + DropdownMenu item. |
| src/app/pipelines/_components/PipelineDropdown.tsx | Refactors delete flow similarly. |
| src/app/pipelines/[pipelineId]/snapshots/page.content.tsx | Reuses shared snapshot table/components. |
| src/app/pipelines/[pipelineId]/snapshots/columns/index.tsx | Removes inlined columns (replaced). |
| src/app/pipelines/[pipelineId]/snapshots/columns.tsx | Uses shared snapshot column creators for pipeline view. |
| src/app/pipelines/[pipelineId]/deployments/page.content.tsx | Reuses shared deployments table/components. |
| src/app/pipelines/[pipelineId]/deployments/colunns/index.tsx | Removes inlined columns (replaced). |
| src/app/pipelines/[pipelineId]/deployments/columns.tsx | Uses shared deployment column creators for pipeline view. |
| src/app/deployments/page.tsx | Adds global deployments page. |
| src/app/deployments/page.content.tsx | Implements global deployments content and table wiring. |
| src/app/deployments/columns.tsx | Column list for global deployments view. |
| package.json | Bumps vite version. |
| CLAUDE.md | Adds repository guidance for Claude Code. |
| AGENTS.md | Adds repo guidelines for tooling. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| if (isPending) return <Skeleton className="h-[300px] w-full" />; | ||
|
|
||
| console.log("TIM WAS HERE", data); |
There was a problem hiding this comment.
Remove leftover console.log used for debugging to avoid noisy logs in production.
Suggested change
| console.log("TIM WAS HERE", data); |
Copilot uses AI. Check for mistakes.
Comment on lines
+62
to
+67
| {exceptionCodeLine && ( | ||
| <div | ||
| className="pointer-events-none absolute h-[24px] w-full bg-red-500/50" | ||
| style={{ top: `${24 * exceptionCodeLine}px` }} | ||
| ></div> | ||
| )} |
There was a problem hiding this comment.
Avoid magic number for line height and falsy checks for numeric props. Use an explicit nullish check and derive offset from a named constant or computed line height; also consider (exceptionCodeLine - 1) for 1-based line numbers.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.