-
Notifications
You must be signed in to change notification settings - Fork 565
Handle deployment url for ingress, gateway etc.. #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
safoinme
wants to merge
14
commits into
develop
Choose a base branch
from
fix/improve-deployment-url-in-k8s-deployer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,149
−48
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4d1c5a0
init
safoinme a71c6db
apply claude review
safoinme d72523a
Merge branch 'develop' into fix/improve-deployment-url-in-k8s-deployer
safoinme a854c3d
Merge branch 'develop' into fix/improve-deployment-url-in-k8s-deployer
safoinme 2181088
fixes
safoinme 525b6a9
Merge branch 'develop' into fix/improve-deployment-url-in-k8s-deployer
safoinme b35c79b
Auto-update of Starter template
actions-user f969d27
Merge branch 'develop' into fix/improve-deployment-url-in-k8s-deployer
htahir1 6774a9f
fix based on claude review
safoinme 5b2c576
Merge branch 'develop' into fix/improve-deployment-url-in-k8s-deployer
safoinme ede0ef3
url review fixes
safoinme f21f82e
Merge branch 'develop' into fix/improve-deployment-url-in-k8s-deployer
safoinme 32ef6c5
fix utils
safoinme 2001b4a
mypy issues
safoinme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -557,6 +557,17 @@ class KubernetesServiceType(StrEnum): | |
| CLUSTER_IP = "ClusterIP" | ||
|
|
||
|
|
||
| class KubernetesUrlPreference(StrEnum): | ||
| """URL preference for Kubernetes deployer when multiple URL types are available.""" | ||
|
|
||
| GATEWAY_API = "gateway_api" | ||
| INGRESS = "ingress" | ||
| LOAD_BALANCER = "load_balancer" | ||
| NODE_PORT = "node_port" | ||
| CLUSTER_IP = "cluster_ip" | ||
| AUTO = "auto" | ||
|
|
||
|
|
||
|
Comment on lines
+560
to
+570
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this belongs in a file somewhere under the kubernetes integration, not here. |
||
| class StepRuntime(StrEnum): | ||
| """All possible runtime modes for a step.""" | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this neat little insight!