fix: bind 127.0.0.1 by default for Docker service ports
#1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Binds `127.0.0.1` as the host IP for all mapped service ports in Docker Compose files. * Allows overriding the host IP using the `DOCKER_SERVICES_IP_BIND` environment variable.
github-project-automation
bot
moved this from In review 🔍
to To release 🤖
in Sprint Q1/2026
Samk13
reviewed
Oct 14, 2025
| image: zenodo:latest | ||
| ports: | ||
| - "5000" | ||
| - "${DOCKER_SERVICES_IP_BIND:-127.0.0.1}:5000" |
There was a problem hiding this comment.
Is this really working for you, or will you get Bind for 127.0.0.1:5000 failed: port is already allocated?
Suggested change
| - "${DOCKER_SERVICES_IP_BIND:-127.0.0.1}:5000" | |
| - "${DOCKER_SERVICES_IP_BIND:-127.0.0.1}:5001:5000" |
Member
Author
There was a problem hiding this comment.
You're right, I didn't test the "full" version of the setup actually 🙈
It should be separate ports, though this UI/API separation hasn't done us any good as a recommendation. E.g. on Zenodo we see equivalent usage, so splitting into separately scalable groups is not utilized... I'll fix here and in the cookiecutter and ask some folks if they see why we shouldn't just keep one container with UI + API app.
Samk13
reviewed
Oct 14, 2025
| image: zenodo:latest | ||
| ports: | ||
| - "5000" | ||
| - "${DOCKER_SERVICES_IP_BIND:-127.0.0.1}:5000" |
There was a problem hiding this comment.
Suggested change
| - "${DOCKER_SERVICES_IP_BIND:-127.0.0.1}:5000" | |
| - "${DOCKER_SERVICES_IP_BIND:-127.0.0.1}:5000:5000" |
Without this, I will get invalid hostPort: 127.0.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
127.0.0.1as the host IP for all mapped service ports inDocker Compose files.
DOCKER_SERVICES_IP_BINDenvironment variable.