This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Android. Edit candidate initial#271
Open
GiantYhorm wants to merge 10 commits into
Open
Conversation
*Removed unnecessary annotations @serialized_name
*Add get internetly/locally detailed interview *Add save and get methods to InterviewDetailPresenter *Add check for null pointers to Lists of objects(strings) in SQLite database
*Fixed bugs with SQLite in interviews list *Add layout,string,dim,presenter and etc. for Edit Candidate fragment *integrate interviews list with rx java *Add butterknife library and use that on interviews list fragment&InterviewsAdapter
trenatov
reviewed
Jul 16, 2018
| @@ -145,7 +145,7 @@ public class SQLiteHelper extends SQLiteOpenHelper { | |||
| ID + " INTEGER_PRIMARY_KEY, " + | |||
| FIRST_NAME + " TEXT, " + | |||
| LAST_NAME + " TEXT, " + | |||
Member
There was a problem hiding this comment.
Why you havent used room db framework)
Contributor
Author
There was a problem hiding this comment.
I've just found out about that. Will know -_-.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.