fix: remove failure stamps when retrying messages to prevent message loss#167
Open
bendavies wants to merge 1 commit into
Open
fix: remove failure stamps when retrying messages to prevent message loss#167bendavies wants to merge 1 commit into
bendavies wants to merge 1 commit into
Conversation
…loss When retrying a failed message via the UI, if it failed again after exhausting retries, the message would be lost instead of being sent back to the failure transport. This occurred because SendFailedMessageToFailureTransportListener checks for an existing SentToFailureTransportStamp and skips sending to the failure transport if found (to avoid re-sending). Since retried messages kept their original stamps, they couldn't be sent back to failure transport on subsequent failures. Now removes SentToFailureTransportStamp, RedeliveryStamp, and ErrorDetailsStamp before dispatching, allowing the message to be properly sent to the failure transport if it fails again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #103 (comment)
When retrying a failed message via the UI, if it failed again after exhausting retries, the message would be lost instead of being sent back to the failure transport.
This occurred because SendFailedMessageToFailureTransportListener checks for an existing SentToFailureTransportStamp and skips sending to the failure transport if found (to avoid re-sending). Since retried messages kept their original stamps, they couldn't be sent back to failure transport on subsequent failures.
Now removes SentToFailureTransportStamp, RedeliveryStamp, and ErrorDetailsStamp before dispatching, allowing the message to be properly sent to the failure transport if it fails again.