fix: remove deprecated $aliasMap parameter from createXmlMappingDriver#175
fix: remove deprecated $aliasMap parameter from createXmlMappingDriver#175KDederichs wants to merge 1 commit into
Conversation
0c5d423 to
b38b51f
Compare
|
Static analysis is failing cause it doesn't accept bool instead of the expected array, not sure if there's some magic ignore comment that makes this go away. Also checking for the parameter name here, because in version 2.10.0 of the doctrine bundle there was a time where there were only 4 parameters as well, 4th one being the $aliasMap array, so we can not check for number of arguments |
|
I ignored the PHPStan error for now to pass the CI since I don't think you can fix that one and still support both versions of the bundle at the same time. |
|
Is there an update? Would be awesome to get this deprecation away 😄 |
|
I'm basically waiting on @kbond to review it to see if I need to change something :) |
While I added a PR to the doctrine bundle to restore the BC, it would be good to just fix the code right away anyways :)
Fixes #174