Skip to content

fix: remove deprecated $aliasMap parameter from createXmlMappingDriver#175

Open
KDederichs wants to merge 1 commit into
zenstruck:1.xfrom
KDederichs:1.x
Open

fix: remove deprecated $aliasMap parameter from createXmlMappingDriver#175
KDederichs wants to merge 1 commit into
zenstruck:1.xfrom
KDederichs:1.x

Conversation

@KDederichs

@KDederichs KDederichs commented Dec 22, 2025

Copy link
Copy Markdown

While I added a PR to the doctrine bundle to restore the BC, it would be good to just fix the code right away anyways :)

Fixes #174

@KDederichs

KDederichs commented Dec 22, 2025

Copy link
Copy Markdown
Author

Static analysis is failing cause it doesn't accept bool instead of the expected array, not sure if there's some magic ignore comment that makes this go away.

Also checking for the parameter name here, because in version 2.10.0 of the doctrine bundle there was a time where there were only 4 parameters as well, 4th one being the $aliasMap array, so we can not check for number of arguments

@KDederichs

Copy link
Copy Markdown
Author

I ignored the PHPStan error for now to pass the CI since I don't think you can fix that one and still support both versions of the bundle at the same time.
If you'd rather do something else with that, let me know.

@PheysX

PheysX commented Feb 3, 2026

Copy link
Copy Markdown

Is there an update? Would be awesome to get this deprecation away 😄

@KDederichs

Copy link
Copy Markdown
Author

I'm basically waiting on @kbond to review it to see if I need to change something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conflict with doctrine-bundle 3.2

2 participants