action: Allow the user to set the west manifest import flag#15
Merged
Conversation
Member
Author
|
Tested here: zephyrproject-rtos/zephyr-testing#291 |
pdgendt
reviewed
Nov 27, 2024
In some cases, when using checked out trees to construct the manifest objects, it is important for users to be able to select which projects are imported, because they may have import statements in their manifests that they may want to honour or not. This commit allows the action user to select between import all projects (the default), none or only the projects in the self: section of the manifest. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
import-flag
branch
from
fd2bc30 to
0a48905
Compare
pdgendt
approved these changes
Nov 27, 2024
pdgendt
left a comment
pdgendt
left a comment
Collaborator
There was a problem hiding this comment.
Not an expert here, but LGTM
Member
Author
|
Self-merging since this is an addition that is not currently required for upstream Zephyr itself, but for other projects using this action with |
carlescufi
added a commit
to carlescufi/zephyr
that referenced
this pull request
Dec 20, 2024
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
kartben
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Dec 20, 2024
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Dec 23, 2024
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 (cherry picked from commit 6e92a3f) Original-Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> GitOrigin-RevId: 6e92a3f Cr-Build-Id: 8727764308049365969 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8727764308049365969 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: If75a1f0ede2bbd6fee7ce89bdd7647eded5e7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/6116712 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Devansh0210
pushed a commit
to Devansh0210/zephyr
that referenced
this pull request
Jan 7, 2025
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
jma-phytec
pushed a commit
to phytec/zephyr-phytec
that referenced
this pull request
Jun 9, 2026
See these PRs for additional information on what changed between v1.5.0 and v1.7.0: zephyrproject-rtos/action-manifest#15 zephyrproject-rtos/action-manifest#16 Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, when using checked out trees to construct the manifest objects, it is important for users to be able to select which projects are imported, because they may have import statements in their manifests that they may want to honour or not.
This commit allows the action user to select between import all projects (the default), none or only the projects in the self: section of the manifest.