Dockerfile: Move all components except Zephyr SDK to the CI base image #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
force-pushed
the
rework_ci_base
branch
from
e6a2df5 to
34982bc
Compare
Until now, the logical separation between the `ci-base` and `ci` images was not so well defined and the components were not organised into each image in a practically useful way. After this change, the `ci-base` image is defined to be an image that includes all tools required for CI operation except the Zephyr SDK, and the `ci` image is defined as an image that includes everything in the `ci-base` image plus the Zephyr SDK. This effectively allows the CI workflows that do not require the Zephyr SDK (e.g. CI workflows for third-party toolchains, or SDK CI workflow that tests an arbitrary SDK build) to use the `ci-base` image. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
force-pushed
the
rework_ci_base
branch
from
34982bc to
e3d1024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the logical separation between the
ci-baseandciimages was not so well defined and the components were not organised into each image in a practically useful way.After this change, the
ci-baseimage is defined to be an image that includes all tools required for CI operation except the Zephyr SDK, and theciimage is defined as an image that includes everything in theci-baseimage plus the Zephyr SDK.This effectively allows the CI workflows that do not require the Zephyr SDK (e.g. CI workflows for third-party toolchains, or SDK CI workflow that tests an arbitrary SDK build) to use the
ci-baseimage.