Skip to content

scripts: genpinctrl: add eth pins for stm32h7rs#297

Merged
erwango merged 2 commits intozephyrproject-rtos:mainfrom
mariopaja:gen_script_h7rs_eth
Aug 25, 2025
Merged

scripts: genpinctrl: add eth pins for stm32h7rs#297
erwango merged 2 commits intozephyrproject-rtos:mainfrom
mariopaja:gen_script_h7rs_eth

Conversation

@mariopaja
Copy link
Copy Markdown
Contributor

@mariopaja mariopaja commented Jul 18, 2025

Update pinctrl-config to generate ETH_MII & ETH_RMII.
STM32H7RS uses a different declaration format for the eth pinctrl compared to H7 or N6 series

Copy link
Copy Markdown
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More context about why these changes are required would be needed.
Also, please add a second commit with the new batch generated with these changes.

@erwango
Copy link
Copy Markdown
Member

erwango commented Jul 23, 2025

@mariopaja Just to be sure, is the last commit is the full output of

python3 scripts/genpinctrl/genpinctrl.py -p /path/to/stm32-open-pin-data-repository

?

I mean the effect of your changes to the whole STM32 family ? Tbh I'd be surprised.
Basically my point is that I want to know the impact of your changes on non H7RS series. And ideally it should be null, but I doubt about it.

@mariopaja
Copy link
Copy Markdown
Contributor Author

@erwango
Using the same commit of STM32_open_pin_data -> Some WBA5 series are affected
Using main branch of STM32_open_pin_data -> several series are affected

I noticed that the issue was the JTAG PORT

Comment thread dts/st/wba/stm32wba50kgux-pinctrl.dtsi Outdated
@erwango
Copy link
Copy Markdown
Member

erwango commented Jul 24, 2025

@mariopaja Can you drop the WBA JTAG PORT changes? This is an issue on our side that should be fixed. Otherwise LGTM


- name: ETH_RMII
match: "^ETH\\d+_RMII_(?:CRS_DV|REF_CLK|RXD[0-1]|RX_CLK|RX_ER|TX_EN|RX_DV|TXD[0-1]|TX_CLK|TX_EN)$"
match: '^ETH\d?_RMII_(?:COL|CRS|RXD[0-3]|RX_CLK|RX_DV|RX_ER|TX_EN|TXD[0-3]|TX_CLK|TX_EN)$'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I wasn't clear enough, but CRS_DV|REF_CLK should stay.

Update pinctrl-config to generate ETH_MII & ETH_RMII.
STM32H7RS uses a different declaration format for the eth pinctrl

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
Add stm32h7rs pinctrl ETH_MII & ETH_RMII

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
@erwango erwango merged commit 85f2cee into zephyrproject-rtos:main Aug 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants